Repository navigation
feat(groups): lead New Chat with groups, push the new chat, slim the Invite People sheet - #1239
Merged
Merged
Conversation
…Invite People sheet New Chat lists Create a New Group first. After Create, the chat replaces the form's path in one assignment so it slides in as a push. The group Invite People sheet drops Recent Chats and its send path, shows one line under the link pill, orders its tiles Copy, Share, QR Code, and wraps its height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the iOS side of the spec in code-payments/flipcash-client-orchestrator#124 (
private-groups.mdsurfaces 1-2,group-invites.mdsurface 1).AppRouter.pushForCollapse(_:)/collapseTopmostPath(toTop:)). Back from the chat goes to the Chats list. Private and community creation share the call.fullScreenCoverto.sheetso it fits its content, and goes to large while the QR card shows. Profile, message and currency shares are unchanged. Analytics events are unchanged.pushForCollapse/collapseTopmostPath. Dropped thesheetMetatest with the helper.