Repository navigation
Conversation
Refs #280. Add bounded deterministic Hypothesis regressions without runtime edits; the separately authorized input-error repair remains in #286 and issue #280 is not closed by this partial tests-only delivery. Independent review, latest-main integration, and all 12 applicable checks passed at 914847b.
|
Compatibility review found an insufficiency in the currently green The existing runtime passed string states through. |
Refs #277. Final delta is exactly the isolated 13 tests/CI/tooling/docs paths; unmerged input-validation changes from #286 are not included. Preserve overall90 and original90/88/84 floors and add seven independently enforced high-risk floors with strong transaction and cleanup regressions. Independent review and all12 applicable checks passed at a35dfb4. Final-tree coverage94.51%, all10 independent floors passed, and the original Windows zero-checkpoint safety assertion passed unchanged. Issue277 remains open until post-merge CI succeeds.
|
Final integrated candidate is frozen at All 12 applicable ordinary checks passed on this exact head: Test 41329852328, Platform 41329852395. Python 3.13: 3568 passed, coverage 94.56%, all ten critical floors; audited, actually installed wheel offline CLI/skills acceptance passed. The source-state compatibility positive and negative properties executed. Actual main's post-merge Test / Platform also passed. Remaining required acceptance — not yet executed: manually dispatch Test on gh workflow run test.yml --repo codeasier/pt-snap-cli --ref fix/input-domain-errors-280Verify the run event/ref/head, actual wheel/source identity and the required installed-wheel dataset results; the paired differential gate must prove 200 seeds per v1/v2 (400 distinct identities), matching coverage/query/scratch evidence and zero unexpected failures/skips. See this head's workflow guide lines 117–119 and 149–161. Ordinary PR event-policy skips are not this evidence. No available connector dispatch action or authorized cloud coding environment was found; no credentials, false events, workflow changes or user Mac are used as a workaround. Refs #280. Keep the tracking issue open and this PR Draft until that required evidence is complete; subsequent normal merge and post-merge checks still apply. |
Integrated candidate and ordinary CI completeThe new frozen target is Independent review and full-tree verification found no integration blocker: all 463 main file entries outside this PR's nine paths and all eight non-provenance PR blobs are unchanged. The only conflict was resolved by retaining main's complete provenance history and appending the original input-validation entry. Both commit identities and ordered parents were verified. No unmerged PR prerequisite remains. All 12 applicable ordinary checks passed on this exact head, attempt 1:
Remaining required manual acceptanceNo In the designated validation environment, open Test → Run workflow, select gh workflow run test.yml --repo codeasier/pt-snap-cli --ref fix/input-domain-errors-280Before accepting the result, verify event/ref/head exactly match this target, the wheel/source identity, both required installed-wheel dataset cases (1,000,000 events and the 500,002-event short-final-shard boundary), and the paired 200-seed v1/v2 profile with 400 distinct identities, matching coverage/query/scratch evidence and zero unexpected failures or skips. See the exact-head workflow guide and differential gate. Older-head or main-branch results do not substitute. Refs #280. The branch is frozen for this acceptance; keep the PR Draft and issue #280 open. Normal final merge checks and post-merge validation remain after the required receipt. No tag, deployment or approval review was performed. |
Scope
Refs #280. This is the separately authorized minimal runtime input-error follow-up, kept out of tests-only PR #282. It does not choose a parser-v3/frame-tree route or change replay/schema/layout behavior.
device_traces=[None]and[{}].Current integration (2026-11-05)
The candidate integrates actual main
d5adcd4a6192e217fe07a3bf27089486cfd91974after PR #269. Headdbf7fe45d2571d2abe0bb39e94eaf3952c7e2a77has parentsbb2bde0e55cc7e7bf789755b3b94aa969b115186andd5adcd4a6192e217fe07a3bf27089486cfd91974, with treec63c475d2dce6828a84816ee3acf41b222c93f50.The only overlapping path was append-only
src/pt_snap_cli/snapshot/PROVENANCE.md: the complete current main history is retained, followed by the original input-validation entry. All eight other PR files retain their reviewed blobs exactly. All 463 main file entries outside this PR's nine paths remain unchanged; the integrated tree has 472 file entries. This preserves PR #269's frame-tree/cache work and all accepted coverage/focus changes. No code, workflow, test assertion, threshold, fixture or dependency was changed for this integration. No unmerged PR prerequisite remains.Validation
The original input-boundary changes and producer-state compatibility correction retain their earlier independent reviews. The current integration has an independent static review and verified complete-tree union, dual commit identity and ordered parents. Ordinary tests/builds remain assigned to existing CI, not duplicated locally. Fresh exact-head ordinary CI is pending; older green runs do not validate this new combination.
Producer block state strings remain unchanged: upstream
active_awaiting_free, unknown strings and empty strings are not restricted to local replay constants. Non-strings are rejected, existing SQL mappings remain intact, and 99 is only the omitted-column default. No awaiting/pending conversion or new state mapping is introduced. Earlier regression evidence does not claim all replay transitions or upstream GUI support.Compatibility and issue #280 acceptance
Refs #280. Keep the tracking issue open until the combined acceptance matrix and post-merge CI are complete; closure will be an explicit issue operation after that evidence. Omitted SQL with complete
query_variantshas an explicit existing authoring/test contract; optional defaults and empty configuration/template objects also have existing tests. Ignored unknown root/query/parameter-definition fields and empty/null loader forms are preserved as existing parser compatibility, not advertised as a general extension API. No contradictory closed-schema rejection rule was found. Illegal shapes/types, missing required fields and non-string block states receive controlled errors. Existing producer state strings remain unchanged; unknown values pass through the current SQL value map, while 99 is only the omitted-column default. No awaiting/pending conversion or new state mapping is introduced. Unknown runtime argument names and unknownoutput_schemafields retain their existing rejection contract. The known malformed-container and numeric escapes are addressed rather than silently xfailed. Pickle remains trusted code execution, not a sandbox.Required final acceptance
Current integrated candidate:
dbf7fe45d2571d2abe0bb39e94eaf3952c7e2a77onfix/input-domain-errors-280. The earlier frozenbb2bde0emanual target is superseded. Wait for this exact candidate's ordinary CI to finish before the final manual dispatch target is confirmed.This snapshot input-boundary change still requires the scheduled/manual installed-wheel dataset acceptance and paired 200-seed profile (400 distinct seed/format identities) from Test, with no custom inputs. The designated validation environment must run the published PR branch and verify the exact run head, wheel/source identity, required dataset results and differential evidence. A PR run's nightly skip, an older head, or a main-branch run is not this evidence.
This PR remains Draft and #280 open until the required exact-head manual evidence, final merge checks and post-merge validation succeed. No workflow/credential/network/runner-policy workaround is introduced.
Snapshot provenance
Snapshot provenance decision: updated
Provenance evaluation: append-only first-party input-validation history added to
src/pt_snap_cli/snapshot/PROVENANCE.md; existing attribution/source mapping/license text remains unchanged. No fixture bytes or source-ownership mapping changed.