Repository navigation
V1.1.0/double digits - #17
Open
gimlichael wants to merge 7 commits into
Open
gimlichael wants to merge 7 commits into
gimlichael wants to merge 7 commits into
Conversation
Shared build properties now target net11.0 alongside net10.0 for the source, test, and benchmark projects so the libraries can be built and tested against .NET 11.
Moves the central package version of Codebelt.Coverlet.MTP to the latest stable release to keep the test coverage tooling current.
Converts affected source and test files to LF line endings and removes stray indentation and trailing whitespace so formatting matches the rest of the codebase.
Updates the README, AGENTS guidance, and availability include to describe .NET 11 alongside .NET 10 as supported targets.
Explains which SDKs contributors need to build and test both target frameworks and describes the updated test loop and CI coverage.
Moves CI runners to Ubuntu 26.04 and opts in to preview SDKs so .NET 11 can be built and tested before its final release. The default availability text in the service update workflow now lists .NET 10 and .NET 11.
Records the .NET 11 target in the package release notes and adds a target framework line to each package README so NuGet consumers see the supported frameworks.
 [Medium impact] The changes reach all five Carter packages and their build and release workflows. The PR appears safe to merge, with a non-blocking correction needed to preserve three package release histories.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1
to
+5
| Version: 1.1.0 | ||
| Availability: .NET 11 and .NET 10 | ||
|
|
||
| # ALM | ||
| - CHANGED Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs) | ||
| - CHANGED Target frameworks by adding .NET 11 (net11.0) so the package now targets .NET 11 and .NET 10 |
There was a problem hiding this comment.
The new 1.1.0 entry replaces 1.0.9 instead of being added above it. The YAML and XML package notes do the same. Because Directory.Build.targets copies each whole file into NuGet release notes, these three packages lose their published 1.0.9 history. Restore that entry below 1.1.0, as the core and Newtonsoft.Json packages already do.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .nuget/Codebelt.Extensions.Carter.AspNetCore.Text.Json/PackageReleaseNotes.txt
Line: 1-5
Comment:
**Previous release notes disappear**
The new `1.1.0` entry replaces `1.0.9` instead of being added above it. The YAML and XML package notes do the same. Because `Directory.Build.targets` copies each whole file into NuGet release notes, these three packages lose their published `1.0.9` history. Restore that entry below `1.1.0`, as the core and Newtonsoft.Json packages already do.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds .NET 11 targeting alongside .NET 10 for the Carter libraries, tests, and benchmark configuration. It updates CI for preview SDKs, aligns framework guidance and package metadata, and normalizes source and test formatting.
Build and CI:
Framework guidance and package metadata:
Formatting consistency: