Repository navigation
VNext/unload module mutex - #4
Merged
Merged
Conversation
The unload mutex was named from the hits file name without its extension, which dropped the session GUID and last namespace segment. Unrelated modules and runtimes could therefore share one mutex through a common assembly-name prefix and block each other. The mutex is now named from the full hits file name, and a regression test covers the legacy prefix collision.
Record the 10.1.1 patch so the fix for module unload mutex collisions between unrelated coverage sessions is documented for users upgrading from 10.1.0.
[Medium impact] The reviewed changes appear safe to merge, with no new blocking issues found. SummaryNames the unload mutex from the complete hit-file name, keeping unrelated coverage sessions separate.
No new actionable issues were found in the changes since the previous review. No previous review threads were supplied. Tests were not run. Reviews (4) · Last reviewed commit: "✅ read runtime package versions from cen..." · Reviewed by Greptile |
Moves the .NET 10 and .NET 9 runtime pins to their latest patch releases so the solution builds and tests against the current runtime baselines.
Aligns the Pkcs override used by coverlet.core with the latest 8.0 patch release.
References the Pkcs package from the MTP validation test project so its tests use the same centrally managed runtime version as the rest of the solution.
Package layout assertions for net9.0 and net10.0 hard-coded Microsoft.Extensions versions, so they went stale whenever the central package file moved. MtpPackageVersions now reads those runtime versions from Directory.Packages.props, keeping the assertions aligned with the single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes module unload mutex collisions between unrelated coverage sessions and records the fix in the changelog as release 10.1.1. Hit files are now used as the mutex name in full, so sessions whose assembly names share a prefix no longer block one another.
Unload mutex fix:
Changelog: