Fix PSR client support and quota retries - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix requests made with PSR-18 clients that do not implement Guzzle’s
request()method. Guzzle clients continue to use their configured transport options. Stop retrying HTTP 429 quota responses, and correct the year-filtered makes example in the README.These fixes are intended for v0.1.1.
Type of Change
Testing
composer validate --strict— passedcomposer lint— passedcomposer test— 7 tests, 18 assertions passed on PHP 8.4Checklist
Related Issues
None linked.
Additional Notes
Applications injecting a non-Guzzle PSR-18 client should configure timeouts and TLS verification on that client. The SDK continues to apply its transport options to Guzzle clients.