feat(blog-hero): configurable gradient overlay over bg_image - #80
Merged
Conversation
Replace the hardcoded 0.7 gradient-overlay opacity with the brand field bg_image_overlay (0.0-1.0, default 0.7 — unchanged behavior when absent). Also fixes the documented --scale default (2.0, not 1.0) and adds bg_image_opacity dark-artwork guidance to the schema. Ref: #74 (item 2 + item 3)
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #74 (item 2 + item 3; the URL-fetch half follows in a separate PR)
What
bg_image_overlay(0.0–1.0, default0.7= the previously hardcoded value, so behavior is unchanged when absent) controlling the gradient overlay opacity on top ofbg_imagebg_image_opacitydescription gains the dark-artwork guidance (~0.55) from the issue--scaledefault (actual: 2.0 retina, was listed as 1.0) and note the 2x default output in the READMEWhy
Issue #74: users cannot control how much gradient sits on top of a background photo (production tuned value was 0.55 with manual template edits), and the documented
--scaledefault contradicted the code.Testing
cargo testfull suite green (template render covered by Verify Templates)bg_image_overlay: 0.3shows visibly more photo than default0.7with title contrast intact (visually verified)