fix(web): import createOAuthState in accounts page - #246
Merged
Conversation
The Connect flow calls createOAuthState() (added in #240) but the import was missing — clicking Connect threw a ReferenceError at runtime. SvelteKit build does not type-check, so CI did not catch it; svelte-check does.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
createOAuthStateimport toweb/src/routes/admin/accounts/+page.svelte.Why
Follow-up to #240: the Connect flow calls
createOAuthState()but the import was missing, so clicking Connect throws a ReferenceError at runtime. SvelteKitbuilddoes not type-check (onlysvelte-checkdoes), which is why CI stayed green on develop.Testing
bun run checkon develop showsCannot find name 'createOAuthState'before this change; gone aftergrep -n createOAuthState web/src/routes/admin/accounts/+page.svelte→ import + call site both present