fix(docker): drop ghost crate references from dependency-cache layer - #324
Merged
Conversation
The dependency-warming stage still COPY-ed Cargo.toml files for trapfall-search, trapfall-alert, and trapfall-dashboard — crates removed in the 9-to-6 consolidation (#305). buildx failed at the COPY cache key ('not found') before compiling anything, so every tag-based image build has been broken since that consolidation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
crates/trapfall-search,crates/trapfall-alert, andcrates/trapfall-dashboardfrom the Dockerfile's manifest-only COPY layer and the matching dummy-srcmkdir block — the crate set now matches the six workspace members.Why
The ghost crates were deleted in the 9-to-6 consolidation (#305), but the Dockerfile kept referencing their
Cargo.tomlpaths. buildx fails at the COPY cache key ("/crates/trapfall-alert/Cargo.toml: not found") before compiling anything, so every tag-based image build has been broken since that consolidation — first observed releasing v0.3.0 (run 33735634590).Testing