Skip to content

fix(agents): hide async hook console window on Windows #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
put4o wants to merge 1 commit into from
Closed

fix(agents): hide async hook console window on Windows #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/agents/plugins/codemie-code-hooks/__tests__/shell-hooks-source.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ beforeEach(() => {
});

describe('SHELL_HOOKS_PLUGIN_SOURCE', () => {
it('hides the console window for asynchronous hook commands', () => {
expect(SHELL_HOOKS_PLUGIN_SOURCE).toMatch(
/spawn\("sh",\s*\["-c", command\],[\s\S]*?windowsHide:\s*true/,
);
});

it('exports an async factory returning flat dotted-key handlers', async () => {
const hooks = await loadHooks(['UserPromptSubmit']);

Expand Down
1 change: 1 addition & 0 deletions src/agents/plugins/codemie-code-hooks/shell-hooks-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ function execCommandAsync(
env: { ...process.env, ...env },
stdio: ["pipe", "ignore", "ignore"],
detached: true,
windowsHide: true,
});
// A ChildProcess or stdin 'error' with no listener is an UNHANDLED error
// event, which throws inside the host OpenCode process. Stop is configured
Expand Down
Loading