revert(providers): remove mandatory LiteLLM/SSO enforcement gate from setup - #524
Merged
8nevil8 merged 3 commits intoSep 3, 2026
Merged
Conversation
… setup Reverts the EPMCDME-11733 enforcement gate (#429) and its follow-on fixes (#457, #458, #459, #500): `codemie setup` no longer authenticates to CodeMie and checks for a project-scoped LiteLLM integration before letting the user pick a provider. Provider selection is back to a single plain prompt, and SSOSetupSteps/LiteLLMSetupSteps no longer take a SetupContext for enforced credentials or session reuse. - setup.ts: drop detectLiteLLMEnforcement, CODEMIE_BACKED_PROVIDERS, isPromptAbortError; provider selection is one inquirer prompt again. - types.ts: remove SetupContext and CodeMieSetupSession; getCredentials() back to its original 1-arg signature. - codemie-auth-helpers.ts: promptForCodeMieUrl back to its 2-param signature. - sso.setup-steps.ts / litellm.setup-steps.ts: always prompt fresh, no enforced-integration banner, no session reuse. - Delete the two test files created solely to cover the reverted feature; trim the allowEmpty-specific assertions from codemie-auth-helpers.test.ts. - agent-setup.test.ts: drop the enforcement-gate PTY step so the e2e test matches the restored plain SSO flow. This file also carries a pre-existing, unrelated workspace-field alignment (007 migration) that predates this change and was not authored here. Kept intact: the unrelated displaySetupInstructions removal and the fetchModels stale-list fix from #500/#491.
Collapses the npm test-script surface to exactly two entry points: npm test runs the full local suite (unit + cli + agent, sequentially, same suite the release process runs), and npm run ci is the CI/release gate (license-check + lint + build + unit + cli, no live credentials needed). test:coverage/test:watch/test:ui stay as-is (different modes, not duplicate suite selectors). Removed as redundant: test:unit, test:integration, test:integration:cli, test:integration:vscode-models, test:integration:agent, test:run, test:all. None had a functional consumer left after inlining ci's test steps directly and pointing scoped/manual runs at npx vitest run --project unit|cli|agent instead. Updated every live reference so nothing points at a removed script name: CONTRIBUTING.md, tests/README.md, the quality-gates/development-practices/ testing-patterns guides, the qa-lead agent, the codemie-release skill, docs/COMMANDS.md, agent-build-setup.ts, and the per-test "Run with:" header comments across tests/integration/agent-*.test.ts and proxy-daemon-lifecycle.test.ts. Also fixed scripts/release.sh, which shelled out to npm run test:integration:agent directly as its pre-tag release gate, repointed to npx vitest run --project agent so the release flow keeps working. agent-model.test.ts is committed separately: staging it alongside these runs its live SSO agent-model test via lint-staged, which is flaky (known upstream transcript-persistence gap, #523) and kept blocking this commit.
The CI test-ubuntu/test-windows jobs still called npm run test:unit and npm run test:integration, both removed by the prior test-script simplification commit — CI failed with "Missing script: test:unit". Repoint at npx vitest run --project unit / --project cli, matching what npm run ci now runs directly.
codemie-ai
approved these changes
Sep 1, 2026
8nevil8
deleted the
chore/revert-litellm-setup-enforcement-and-simplify-tests
branch
September 3, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the EPMCDME-11733 mandatory-LiteLLM-integration enforcement gate (#429) and its four follow-on fixes (#457, #458, #459, #500):
codemie setupno longer authenticates to CodeMie and checks for a project-scoped LiteLLM integration before letting the user pick a provider. Also collapses the npm test-script surface to exactly two entry points, per the same discussion.Changes
revert(providers): ...): dropdetectLiteLLMEnforcement,SetupContext,CodeMieSetupSession, session reuse, and theallowEmptyURL-prompt variant. Provider selection incodemie setupis back to a single plain prompt. Deleted the two test files created solely for the reverted feature.chore(tests): ...):npm testis now the one command for the full local suite (unit + cli + agent — same suite the release process runs);npm run ciis the one CI/release gate (license-check + lint + build + unit + cli). Removedtest:unit,test:integration,test:integration:cli,test:integration:vscode-models,test:integration:agent,test:run,test:allas redundant, and repointed every live doc/comment/script reference (includingscripts/release.sh, which shelled out to a script name that no longer exists) atnpx vitest run --project <unit|cli|agent>or the newnpm test.Notes for reviewers
tests/integration/agent-setup.test.tsalso carries a pre-existing, unrelated workspace-field alignment (007decouple-provider-workspace-configmigration) that predates this branch and wasn't authored as part of this change — it was already in the working tree before this work started.tests/integration/agent-model.test.tsalso carries a pre-existing, unrelatedctx.skipworkaround for a known upstream transcript-persistence gap (#523) that appeared in the working tree mid-session from an unknown source — only its "Run with:" comment line is this branch's intent.src/cli/commands/hook.tshas an unrelated pre-existing local modification that was deliberately excluded from both commits (not part of this branch).Testing
npm run ci(license-check, lint, build, unit, cli) — green, run multiple timesnpm test(unit + cli + agent) — green except the known-flaky live SSO metrics test inagent-model.test.ts, unrelated to this changetests/integration/agent-setup.test.ts(the SSO setup wizard e2e test) to match the restored plain-prompt flow; verified it passes standaloneChecklist