Bind audit seals to exact source jobs - #1058
Conversation
|
Note Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by October 1. Add seats for more headroom. Code Review ✅ Approved🔴 High risk Binds audit seals to exact source Actions job IDs to resolve ambiguity in multi-lane local audit runs, enabling independent Codex and Claude lanes to publish from the same matrix run. Comprehensive test coverage confirms all seal validation scenarios pass, including missing, duplicate same-lane, forged, stale-head, wrong-job, and wrong-attempt proofs. No issues found. Review coverageRules No rules evaluated OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Claude audit (merge-authority lane)Head SHA: |
Multi-lane local audit runs could leave a valid reviewer seal ambiguous at publication time because the artifact identified only the source run and attempt. This change adds the source Actions job ID to the sealed metadata, resolves it from the running lane/job/attempt on the current runner, and requires the successful seal to belong to that exact job. Independent Codex and Claude lanes can now publish from the same matrix run, while missing, duplicate same-lane, forged, stale-head, wrong-job, and wrong-attempt proofs continue to fail closed.
Validation:
python -m pytest -q tests/test_audit_publication.py— 39 passed, 303 subtests passedruff check tools/audit_publication.py src/code_mower/audit_publication.py tests/test_audit_publication.pygit diff --checkpython -m unittest discover -s testsexercised 4,843 tests (19 skipped); its four initial failures were all caused by the uv-created test environment lackingpippipin that environment, all affected tests passed: 5 lineage artifact tests plus the release identity and installed prompt-pack build testsf4713b05926fa2d6f5067583653796f2bfd9c9a6;code-mower/gatepassedCloses #1032