Doctor: make remote observers checkout-independent by jeffhuber · Pull Request #1059 · codemower-ai/code-mower

jeffhuber · 2026-09-20T07:39:06Z

Summary

make doctor --adoption --orchestrator-only --repo OWNER/REPO select a labeled packaged-starter observer plan when no repository config is available
keep checkout, local wrapper, unselected provider/campaign/Cloud, and product-test checks out of remote-only reports while preserving repository GitHub and Actions checks
use stable package labels and redact executable, config, checkout, and workflow paths from the share-oriented observer report
document the observer contract and distinguish local wrapper credentials from repository Actions secret presence

Closes #1053.

Validation

pytest -q tests/test_doctor_*.py tests/test_adoption_*.py — 404 passed, 132 subtests passed
focused doctor/registry/GitHub/output/review-hygiene suite — 86 passed, 9 subtests passed
python -m ruff check .
git diff --check
live checkout-free command against codemower-ai/code-mower — PASS, 22 checks, 0 warnings, no local checkout or package path in JSON

Risk / Rollback

low behavior risk: the narrowed defaults apply only to orchestrator-only adoption; explicit --cloud, --probe-runtime, and --campaign selections remain available
v1.5.1: clarify status, Board version, and share-oriented privacy #1055 may broaden share-oriented privacy to other doctor/status/Board surfaces; this PR's redaction is opt-in and scoped to the packaged-starter remote-observer plan
rollback by reverting this commit restores the v1.5.0 preflight expansion

Data Or Secret Exposure

This change does not add source, raw diffs, raw transcripts, raw provider output, tokens, or machine-specific paths to public artifacts.

gitar-bot · 2026-09-20T07:40:52Z

+    if args.adoption_posture == "orchestrator-only":
+        # The adoption preset predates observer postures and expands to local
+        # runtime plus optional Cloud checks.  Those are useful on a reviewer
+        # host, but an orchestrator only needs the repository-facing checks it
+        # selected.  Preserve deliberate additions to the command line.
+        if not cloud_explicit:
+            args.cloud = False
+        if not runtime_probe_explicit:
+            args.probe_runtime = False


⚠️ Bug: --orchestrator-only now silently disables cloud/probe-runtime for real repos

In src/code_mower/doctor.py:379-387, the new logic forces args.cloud = False and args.probe_runtime = False whenever adoption_posture == "orchestrator-only", gated only on the CLI flag, with no check on whether a real repository config or checkout is present. This is broader than the PR's stated goal of narrowing only the checkout-free packaged_starter_remote_observer plan (which in runner.py additionally requires using_packaged_example and a matching config_source). As a result, an orchestrator-only user with a real code-mower.yml checkout now silently loses the Cloud and runtime-probe checks that --adoption/--preflight previously enabled via apply_first_run_defaults, contradicting the --adoption-posture help text which still states orchestrator-only "keep[s] GitHub/cloud/setup checks visible." Scope the suppression to the same packaged_observer_plan condition used in runner.py (e.g., recompute or pass through the same using_packaged_example/config_source signal) rather than keying off posture alone.

Restrict the cloud/probe-runtime suppression to the checkout-free packaged-starter scenario instead of applying it to every orchestrator-only invocation.:

if args.adoption_posture == "orchestrator-only" and not explicit_config and args.config == "code-mower.yml": # Only narrow defaults for the checkout-free packaged-starter case; # a real repository config keeps cloud/probe-runtime as first-run defaults. if not cloud_explicit: args.cloud = False if not runtime_probe_explicit: args.probe_runtime = False

_{Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-09-20T07:40:53Z

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by October 1. Add seats for more headroom.
Learn more

Code Review ⚠️ Changes requested 0 closed / 1 findings

🟡 Medium risk

Makes remote observers checkout-independent by narrowing defaults for the packaged-starter remote-observer plan, but --orchestrator-only now silently disables cloud and probe-runtime checks for real repositories with code-mower.yml configs. Scope the suppression to match the packaged_observer_plan condition in runner.py rather than keying off posture alone, so explicit adoptions with real checkouts retain those checks as documented.

⚠️

Bug: --orchestrator-only now silently disables cloud/probe-runtime for real repos

📄 src/code_mower/doctor.py:379-387

In src/code_mower/doctor.py:379-387, the new logic forces args.cloud = False and args.probe_runtime = False whenever adoption_posture == "orchestrator-only", gated only on the CLI flag, with no check on whether a real repository config or checkout is present. This is broader than the PR's stated goal of narrowing only the checkout-free packaged_starter_remote_observer plan (which in runner.py additionally requires using_packaged_example and a matching config_source). As a result, an orchestrator-only user with a real code-mower.yml checkout now silently loses the Cloud and runtime-probe checks that --adoption/--preflight previously enabled via apply_first_run_defaults, contradicting the --adoption-posture help text which still states orchestrator-only "keep[s] GitHub/cloud/setup checks visible." Scope the suppression to the same packaged_observer_plan condition used in runner.py (e.g., recompute or pass through the same using_packaged_example/config_source signal) rather than keying off posture alone.

Restrict the cloud/probe-runtime suppression to the checkout-free packaged-starter scenario instead of applying it to every orchestrator-only invocation.

if args.adoption_posture == "orchestrator-only" and not explicit_config and args.config == "code-mower.yml":
    # Only narrow defaults for the checkout-free packaged-starter case;
    # a real repository config keeps cloud/probe-runtime as first-run defaults.
    if not cloud_explicit:
        args.cloud = False
    if not runtime_probe_explicit:
        args.probe_runtime = False

🤖 Prompt for agents

Code Review: Makes remote observers checkout-independent by narrowing defaults for the packaged-starter remote-observer plan, but `--orchestrator-only` now silently disables cloud and probe-runtime checks for real repositories with `code-mower.yml` configs. Scope the suppression to match the `packaged_observer_plan` condition in runner.py rather than keying off posture alone, so explicit adoptions with real checkouts retain those checks as documented.

1. ⚠️ Bug: --orchestrator-only now silently disables cloud/probe-runtime for real repos
   Files: src/code_mower/doctor.py:379-387

   In src/code_mower/doctor.py:379-387, the new logic forces `args.cloud = False` and `args.probe_runtime = False` whenever `adoption_posture == "orchestrator-only"`, gated only on the CLI flag, with no check on whether a real repository config or checkout is present. This is broader than the PR's stated goal of narrowing only the checkout-free `packaged_starter_remote_observer` plan (which in runner.py additionally requires `using_packaged_example` and a matching `config_source`). As a result, an orchestrator-only user with a real `code-mower.yml` checkout now silently loses the Cloud and runtime-probe checks that `--adoption`/`--preflight` previously enabled via `apply_first_run_defaults`, contradicting the `--adoption-posture` help text which still states orchestrator-only "keep[s] GitHub/cloud/setup checks visible." Scope the suppression to the same `packaged_observer_plan` condition used in runner.py (e.g., recompute or pass through the same using_packaged_example/config_source signal) rather than keying off posture alone.

   Fix (Restrict the cloud/probe-runtime suppression to the checkout-free packaged-starter scenario instead of applying it to every orchestrator-only invocation.):
   if args.adoption_posture == "orchestrator-only" and not explicit_config and args.config == "code-mower.yml":
       # Only narrow defaults for the checkout-free packaged-starter case;
       # a real repository config keeps cloud/probe-runtime as first-run defaults.
       if not cloud_explicit:
           args.cloud = False
       if not runtime_probe_explicit:
           args.probe_runtime = False

Review coverage

Rules No rules evaluated

Functional validation Not enabled · Set up

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

github-actions · 2026-09-20T07:44:05Z

Claude audit unavailable

Head SHA: 9d033298f6d0de2f6ca314a5b535446237303cf6
Verdict: UNKNOWN
No merge-authority verdict was published. The local artifact was quarantined, stale, or inconclusive. Check the local runner and requeue this audit.

github-actions · 2026-09-20T07:54:25Z

Claude audit (merge-authority lane)

Head SHA: 1a620e0ba65320c9539357db95296e87e3c7b186
Verdict: PASS
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 7b7d748760aed196d49f83b1371a48fc2cca21f6

github-actions · 2026-09-20T07:56:22Z

Code Mower notice: previously audited head 1a620e0ba653 is no longer an ancestor of current head 4fa841eb1353; commits may have been dropped. Only current-head audit verdicts count.

github-actions · 2026-09-20T08:02:56Z

Claude audit (merge-authority lane)

Head SHA: 4fa841eb1353f53fea45fcb9ebd5ac8e8418c2ac
Verdict: BLOCKED
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 7b7d748760aed196d49f83b1371a48fc2cca21f6

github-actions · 2026-09-20T08:05:48Z

Code Mower notice: previously audited head 1a620e0ba653 is no longer an ancestor of current head 324b4925dab9; commits may have been dropped. Only current-head audit verdicts count.

github-actions · 2026-09-20T08:05:52Z

Code Mower notice: previously audited head 1a620e0ba653 is no longer an ancestor of current head 324b4925dab9; commits may have been dropped. Only current-head audit verdicts count.

github-actions · 2026-09-20T08:10:03Z

Claude audit (merge-authority lane)

Head SHA: 324b4925dab95ad3555507490cc55d6ea12e7486
Verdict: PASS
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 7b7d748760aed196d49f83b1371a48fc2cca21f6

jeffhuber added needs-claude-audit builder:codex Code Mower generated label labels Sep 20, 2026

gitar-bot Bot reviewed Sep 20, 2026

View reviewed changes

jeffhuber force-pushed the codex/1053-remote-doctor branch from 499fdd6 to 1a620e0 Compare September 20, 2026 07:46

jeffhuber added claude-audit-done and removed needs-claude-audit labels Sep 20, 2026

jeffhuber enabled auto-merge (squash) September 20, 2026 07:55

jeffhuber added 2 commits September 20, 2026 02:56

Doctor: scope checkout-free observer plans

7bd0dc4

Doctor: preserve real-config preflight defaults

4fa841e

jeffhuber force-pushed the codex/1053-remote-doctor branch from 1a620e0 to 4fa841e Compare September 20, 2026 07:56

jeffhuber added needs-claude-audit and removed claude-audit-done labels Sep 20, 2026

jeffhuber added claude-audit-blocked and removed needs-claude-audit labels Sep 20, 2026

Clarify doctor argv and hermetic GitHub probe test

324b492

github-actions Bot added needs-claude-audit and removed claude-audit-blocked labels Sep 20, 2026

jeffhuber added needs-claude-audit and removed needs-claude-audit labels Sep 20, 2026

jeffhuber added claude-audit-done and removed needs-claude-audit labels Sep 20, 2026

jeffhuber merged commit 8d2538b into main Sep 20, 2026
22 checks passed

jeffhuber deleted the codex/1053-remote-doctor branch September 20, 2026 08:12

This was referenced Sep 20, 2026

Status: clarify optional lineage and Board version #1060

Merged

Release: prepare v1.5.1 reliability candidate #1061

Merged

v1.5.1: harden cross-provider installation and hosted adoption #1050

Closed

Navigation Menu

Doctor: make remote observers checkout-independent - #1059

Doctor: make remote observers checkout-independent#1059
jeffhuber merged 3 commits into
mainfrom
codex/1053-remote-doctor

jeffhuber commented Sep 20, 2026

Uh oh!

gitar-bot Bot Sep 20, 2026 •

edited

Loading

Uh oh!

gitar-bot Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jeffhuber commented Sep 20, 2026

Summary

Validation

Risk / Rollback

Data Or Secret Exposure

Uh oh!

gitar-bot Bot Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026

Claude audit unavailable

Uh oh!

github-actions Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Claude audit (merge-authority lane)

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Claude audit (merge-authority lane)

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Claude audit (merge-authority lane)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gitar-bot Bot Sep 20, 2026 •

edited

Loading

github-actions Bot commented Sep 20, 2026 •

edited

Loading

github-actions Bot commented Sep 20, 2026 •

edited

Loading

github-actions Bot commented Sep 20, 2026 •

edited

Loading