Skip to content

docs: note Apple Developer Program requirement, add CODEOWNERS - #270

Merged
ethanndickson merged 1 commit into
mainfrom
ethan/contributing-signing
Sep 17, 2026
Merged

ethanndickson merged 1 commit into
mainfrom
ethan/contributing-signing

Conversation

@ethanndickson

Copy link
Copy Markdown
Member

Running the app locally requires signing the System Extension with a provisioning profile that grants the Network Extensions and System Extension capabilities, so anyone not on the Coder Apple Developer team hits a signing error the moment they try to build in Xcode. This wasn't mentioned anywhere in CONTRIBUTING.md, so I've added a couple of sentences pointing employees to Slack for an invite, and noting that external contributors need a paid membership and to swap out our team ID and bundle identifiers.

I've also added a CODEOWNERS, matching terraform-provider-coderd.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T05:20:58.337227Z ace14de PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ethanndickson
ethanndickson merged commit 8006bb3 into main Sep 17, 2026
3 checks passed
@ethanndickson
ethanndickson deleted the ethan/contributing-signing branch September 17, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants