🤖 tests: record in-page perf milestones for workspace open - #4456
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workspace-open perf scenarios now record in-page milestone times: first transcript row ("useful content ready"),
data-loaded("fully revealed"), and the longest main-thread task. They're written intoperf-summary.json, so these numbers no longer depend on when Playwright's assertion polling happens to notice the change. Addresses #4441.Background
The nightly
workspace-open-largenumbers stepped up on 09-21. The investigation in #4441 showed that was mostly a change in what the spec measures, not extra work:data-loadedmilestone later.toHaveAttributepolls with a +100/+250/+500/+1000 ms backoff, so the gap between the real flip and the passing poll went from ~27 ms to ~423 ms.The small real leftover was fixed by #4427.
Implementation
tests/e2e/utils/pageMilestones.ts:chat-messagerow inside the message window and thedata-loaded="true"flip. Its callbacks run in the same task as the DOM change, so there is no polling quantization.longtaskPerformanceObserver records the longest task, and pending entries are drained on read.writePerfArtifactstakes an optionalmilestonesfield, written as a top-level key. The change is additive, soschemaVersionstays 1.fullyLoadedMswas captured.Validation
Local, dist build:
perf.workspaceOpen.spec.ts --repeat-each=3, 18/18 passed. Medians in ms:The last column is the polling overhead that the old wall-clock number included.
Risks
Test-only. The observer adds one or two
querySelectorcalls per mutation batch inside the profiled window, until both milestones are seen. That's negligible next to the ~800 ms of script time.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high