Repository navigation
fix: prove guest Clerk linking on MySQL and add CI - #115
Merged
Merged
Conversation
✅ Deploy Preview for codetv ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for codetv-automations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for codetv-links ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #114, which merged without CI or review. This PR adds both, and proves the path the original bug hit.
What it fixes
Proof
users.mysql.test.tsruns the realgetCourseBuilderUserForClerkUseragainst MySQL tables generated fromsrc/db/schema.ts, seeding a guest-checkout row and linking a Clerk user by email. 8 cases at utf8mb4 and again at utf8mb3, including a 256-char avatar (the original bug), a 261-char name, emoji names, keeping a stored image, and keeping a stored name when the fallback fires.AFE_TEST_MYSQL_URLis unset.CI (
.github/workflows/ci.yml): on pull requests and pushes to main, with a MySQL 8 service, pnpm frozen install, and the website tests.workshop-not-found.test.tsis excluded with a comment: it already fails on main (21268df) withno-storevs an expected public cache header. That needs its own fix.packageManagerin the rootpackage.json, so CI uses pnpm 10 until one is added.Asks for a maintainer: protect
mainand require one review plus this check. The bot can't change repo settings.Out of scope, noted: the email column on insert and the
fieldscolumn aren't length-guarded.SR 🐀