You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
style: rebuild workshop lesson pages on the site layout - #116
Rebuilds the workshop lesson pages (welcome and every chapter) on the site's own patterns. A read-only review measured them against the rest of the site and found they were a bare template: 0 px between paragraphs and headings, about 148 characters a line on desktop, and a video box as tall as the screen (358×844 on a phone, 76% black bars), which caused a mobile layout shift of 0.69–0.72. Every other page on the site is at 0.07 or less.
Commits, in order
fix: reserve the workshop lesson video aspect ratio: the player sits in a 16:9 box sized before the player script loads. The shared Mux player component is unchanged.
style: share workshop prose styles with lesson pages: the landing page's .workshop-body rules move into src/styles/workshop-body.css, imported by both routes. Shared, not copied, and the landing page should render the same. Adds code/pre styles (the site's monospace face, as on the blog) and a callout style for blockquotes, so the chapter 3 safety note reads as a warning.
style: use the site Block layout for workshop lessons: the site's Block grid, the --black background, a landing-style heading, a styled breadcrumb, and Previous/Next as .button links that wrap on phones. Presentation only: the lock, preview and owner logic is byte-identical to main.
fix: label released workshop chapters as unlocked: past dates no longer say "Unlocks …". It adds one test.
Checks
Website tests, as CI runs them, pass.
The isolated pnpm --filter @codetv/website build passes.
Prettier and git diff --check pass.
Before/after captures and mobile CLS on the deploy preview follow in a comment.
Please don't merge until Joel or Jason approves the preview.
Deploy preview checked at 6417f42 (signed in as a test account with lesson access, 390×844 and 1440×900; same measuring script as the original review).
Before (live)
After (preview)
Layout shift on load, phone
0.25–0.72
0–0.012
Layout shift on load, desktop
0.09–0.39
0–0.001
Video box, phone / desktop
358×844 / 1120×900
371×208 / 920×518 (16:9)
Characters per line, desktop
~148
65–73
Body text
16px / 1.45
17–18px / 1.6
Gap after headings / between list items
0 / 0 px
12 / 8 px
Previous / Next
text links
2 .buttons
Horizontal overflow at 390
none
none
Workshop landing page
18px, 67–73 chars, CLS 0.003
unchanged (18px, 67–73 chars, CLS 0.001)
The chapter 3 safety blockquote renders as a callout with a gold left rule. A blind review found no access-logic issues. Its one catch (code blocks on the dark page) is fixed in 6417f42. CI is green.
Screenshots are shared privately, because they show paid lesson content. Waiting for an owner's approval before merge.
Live on production as deploy 6af37f2b (539e2de), published 20:35:59Z. Measured again on codetv.dev, signed in as a QA account with lesson access:
Before (live, this morning)
Production now
Layout shift on load, 390 / 1440
0.25–0.72 / 0.09–0.39
0.012 / 0.001
Video box, 390 / 1440
358×844 / 1120×900
371×208 / 920×518
Characters per line, 1440
~148
73
Body text
16px / 1.45
18px (17px on phones) / 1.6
Gap after headings / between list items
0 / 0 px
12 / 8 px
Horizontal overflow at 390
none
none
Workshop landing page
608px column, 67–73 chars
unchanged, CLS 0
Signed-in check: the lesson page and video play with a signed token (manifest 200 with the token, 403 without). Result OK.
Logs: 149 lines over the first 15 minutes after publish, with no lesson-path errors. The only error lines are a known, pre-existing role-validation message from the QA account's temporary reviewer role.
SR 🐀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the workshop lesson pages (welcome and every chapter) on the site's own patterns. A read-only review measured them against the rest of the site and found they were a bare template: 0 px between paragraphs and headings, about 148 characters a line on desktop, and a video box as tall as the screen (358×844 on a phone, 76% black bars), which caused a mobile layout shift of 0.69–0.72. Every other page on the site is at 0.07 or less.
Commits, in order
fix: reserve the workshop lesson video aspect ratio: the player sits in a 16:9 box sized before the player script loads. The shared Mux player component is unchanged.style: share workshop prose styles with lesson pages: the landing page's.workshop-bodyrules move intosrc/styles/workshop-body.css, imported by both routes. Shared, not copied, and the landing page should render the same. Adds code/pre styles (the site's monospace face, as on the blog) and a callout style for blockquotes, so the chapter 3 safety note reads as a warning.style: use the site Block layout for workshop lessons: the site'sBlockgrid, the--blackbackground, a landing-style heading, a styled breadcrumb, and Previous/Next as.buttonlinks that wrap on phones. Presentation only: the lock, preview and owner logic is byte-identical to main.fix: label released workshop chapters as unlocked: past dates no longer say "Unlocks …". It adds one test.Checks
pnpm --filter @codetv/website buildpasses.git diff --checkpass.Before/after captures and mobile CLS on the deploy preview follow in a comment.
Please don't merge until Joel or Jason approves the preview.
SR 🐀