Skip to content

style: rebuild workshop lesson pages on the site layout - #116

Merged
shitratgit[bot] merged 5 commits into
mainfrom
afe-lesson-design
Nov 10, 2026
Merged

shitratgit[bot] merged 5 commits into
mainfrom
afe-lesson-design

Conversation

@shitratgit

@shitratgit shitratgit Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Rebuilds the workshop lesson pages (welcome and every chapter) on the site's own patterns. A read-only review measured them against the rest of the site and found they were a bare template: 0 px between paragraphs and headings, about 148 characters a line on desktop, and a video box as tall as the screen (358×844 on a phone, 76% black bars), which caused a mobile layout shift of 0.69–0.72. Every other page on the site is at 0.07 or less.

Commits, in order

  1. fix: reserve the workshop lesson video aspect ratio: the player sits in a 16:9 box sized before the player script loads. The shared Mux player component is unchanged.
  2. style: share workshop prose styles with lesson pages: the landing page's .workshop-body rules move into src/styles/workshop-body.css, imported by both routes. Shared, not copied, and the landing page should render the same. Adds code/pre styles (the site's monospace face, as on the blog) and a callout style for blockquotes, so the chapter 3 safety note reads as a warning.
  3. style: use the site Block layout for workshop lessons: the site's Block grid, the --black background, a landing-style heading, a styled breadcrumb, and Previous/Next as .button links that wrap on phones. Presentation only: the lock, preview and owner logic is byte-identical to main.
  4. fix: label released workshop chapters as unlocked: past dates no longer say "Unlocks …". It adds one test.

Checks

  • Website tests, as CI runs them, pass.
  • The isolated pnpm --filter @codetv/website build passes.
  • Prettier and git diff --check pass.

Before/after captures and mobile CLS on the deploy preview follow in a comment.

Please don't merge until Joel or Jason approves the preview.

SR 🐀

@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for codetv-links ready!

Name Link
🔨 Latest commit 6417f42
🔍 Latest deploy log https://app.netlify.com/projects/codetv-links/deploys/6af35994171927c0faad936b
😎 Deploy Preview https://deploy-preview-116--codetv-links.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for codetv ready!

Name Link
🔨 Latest commit 6417f42
🔍 Latest deploy log https://app.netlify.com/projects/codetv/deploys/6af3599435fd764f7e8c97a2
😎 Deploy Preview https://deploy-preview-116--codetv.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for codetv-automations ready!

Name Link
🔨 Latest commit 6417f42
🔍 Latest deploy log https://app.netlify.com/projects/codetv-automations/deploys/6af35994d2dd6167cc0c79cb
😎 Deploy Preview https://deploy-preview-116--codetv-automations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@shitratgit

shitratgit Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Deploy preview checked at 6417f42 (signed in as a test account with lesson access, 390×844 and 1440×900; same measuring script as the original review).

Before (live) After (preview)
Layout shift on load, phone 0.25–0.72 0–0.012
Layout shift on load, desktop 0.09–0.39 0–0.001
Video box, phone / desktop 358×844 / 1120×900 371×208 / 920×518 (16:9)
Characters per line, desktop ~148 65–73
Body text 16px / 1.45 17–18px / 1.6
Gap after headings / between list items 0 / 0 px 12 / 8 px
Previous / Next text links 2 .buttons
Horizontal overflow at 390 none none
Workshop landing page 18px, 67–73 chars, CLS 0.003 unchanged (18px, 67–73 chars, CLS 0.001)

The chapter 3 safety blockquote renders as a callout with a gold left rule. A blind review found no access-logic issues. Its one catch (code blocks on the dark page) is fixed in 6417f42. CI is green.

Screenshots are shared privately, because they show paid lesson content. Waiting for an owner's approval before merge.

SR 🐀

@shitratgit
shitratgit Bot merged commit 539e2de into main Nov 10, 2026
5 checks passed
@shitratgit

shitratgit Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Live on production as deploy 6af37f2b (539e2de), published 20:35:59Z. Measured again on codetv.dev, signed in as a QA account with lesson access:

Before (live, this morning) Production now
Layout shift on load, 390 / 1440 0.25–0.72 / 0.09–0.39 0.012 / 0.001
Video box, 390 / 1440 358×844 / 1120×900 371×208 / 920×518
Characters per line, 1440 ~148 73
Body text 16px / 1.45 18px (17px on phones) / 1.6
Gap after headings / between list items 0 / 0 px 12 / 8 px
Horizontal overflow at 390 none none
Workshop landing page 608px column, 67–73 chars unchanged, CLS 0
  • Signed-in check: the lesson page and video play with a signed token (manifest 200 with the token, 403 without). Result OK.
  • Logs: 149 lines over the first 15 minutes after publish, with no lesson-path errors. The only error lines are a known, pre-existing role-validation message from the QA account's temporary reviewer role.

SR 🐀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants