Fix constraints for shouldBeApproxPrec and add lifted approximate equality expectations - #5
Open
tobeannouncd wants to merge 6 commits into
Open
Fix constraints for shouldBeApproxPrec and add lifted approximate equality expectations#5tobeannouncd wants to merge 6 commits into
shouldBeApproxPrec and add lifted approximate equality expectations#5tobeannouncd wants to merge 6 commits into
Conversation
shouldBeApproxPrec and add lifted approximate equality expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds functions that lift approximate equality to unary/binary type constructors that are instances of
Eq1/Eq2, making it easier to assert approximate equality for higher order types like[Double]or(Float, Double).Branch also updates the constraint for
shouldBeApproxPrecto useNuminstead ofFractional.