Conversation
`PhpIdentifier::words()` treated every non-ASCII character as a word boundary and discarded it, so "Straße" became "StraE", "Müller" became "MLler", and "café" became "Caf". This affected schema/component names, property names, and string-backed enum case names. Fold the input through `Illuminate\Support\Str::ascii()` before splitting, so diacritics/ligatures in any Latin-script language transliterate to their closest ASCII form instead of vanishing. A script with no ASCII equivalent still falls back to the existing empty-result behavior. Assisted-by: Claude Sonnet 5 via Claude Code
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lapotor
marked this pull request as ready for review
August 31, 2026 16:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PhpIdentifier::words()treated every non-ASCII character as a separator and discarded it (e.g. "Straße" -> "StraE"), so it now folds input throughIlluminate\Support\Str::ascii()first, transliterating diacritics/ligatures in any Latin-script language to their closest ASCII form ("Straße" -> "Strasse").Checklist
fix(emitter): ...)composer validateand the quality gates pass (composer qa)Assisted-by: Claude Sonnet 5 via Claude Code