feat: introduce canonical active prop to Chip component family - #843
Open
cb-ekuersch wants to merge 6 commits into
Open
feat: introduce canonical active prop to Chip component family#843cb-ekuersch wants to merge 6 commits into
cb-ekuersch wants to merge 6 commits into
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
-1/1
|
Denominator calculation
|
Introduce active/activeBackground/activeColor on Chip, InputChip, and SelectChip, and update docs, Code Connect, and the expo config playground. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
cb-ekuersch
force-pushed
the
chip-prepare
branch
from
August 13, 2026 19:48
c9924a6 to
6a5a0a1
Compare
cb-ekuersch
marked this pull request as ready for review
August 13, 2026 20:04
Contributor
| const WrappedSelectChipControl = useMemo( | ||
| () => | ||
| createSelectChipControlWrapper<Type, SelectOptionValue>({ | ||
| active, |
Contributor
There was a problem hiding this comment.
I'm concerned that active flipping now remounts the select control. createSelectChipControlWrapper is memoized on the chip props, and active is now one of them, so the first selection (and clearing back to empty) produces a new component type for SelectControlComponent. React unmounts/remounts the whole control: the trigger button loses focus and AnimatedCaret restarts. Previously the deps were effectively static. A stable wrapper that reads chip props from a ref/context (or passing chip props through Select) avoids this.
The default caret now follows color/activeColor instead of always using fg, and SelectChip value typing is tightened off unknown. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Selected tabs need to paint activeBackground/activeColor from tab props and only invert when there is no custom background, now via active instead of invertColorScheme. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
adrienzheng-cb
requested changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Replaces Chip's
invertColorScheme/ inverted emphasis with a canonicalactivestate API across web and mobile.active,activeBackground, andactiveColorto Chip, InputChip, and SelectChip (web + mobile).activeis the public emphasis path; InputChip remains active by default (active={false}for the quieter look).getSelectChipActiveand tighten SelectChip/SelectChipControl prop types with light refactor/reorganization of types.activeAPI.N/A
UI changes
Example utilizing active colors in component config:
Testing
How has it been tested?
Testing instructions
active(andactiveBackground/activeColoroverrides).active={false}.getSelectChipActive.Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**N/A
Change management
type=routine
risk=low
impact=sev5
automerge=false