Repository navigation
test(local-agent-loop): Claude の途中使用量のテスト名を実装に合わせ、includePartialMessages の受け渡しを確かめる - #299
Merged
Merged
Conversation
…ges の受け渡しを確かめる Refs #298 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YE1FnUCruD4Mtwbjx3nyq
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#297（ADR-0034）の最終レビューで残った、動作に影響しない指摘 2 件を直す。
claudePartialUsageのテスト名を実装（同じ応答は 1 回だけ、leg ごとに見えた最大の値で数える）に合わせ、値が減る通知で合計が下がらないことを確かめるテストを足した。ClaudeProvider.callがonPartialUsageのあるときだけincludePartialMessages: trueを provider に渡すことを、CLI を起動せずに確かめるテストを足した。そのためにClaudeProviderのコンストラクタに、claudeCodeとgenerateTextを差し替える省略可能な引数を設けた（既定値は今までと同じ関数で、差し替えるのはテストだけ）。Closes #298
Changes
Test plan
onPartialUsageがあるClaudeProvider.callは、provider 設定にincludePartialMessages: trueを渡す。onPartialUsageがないClaudeProvider.callは、provider 設定にincludePartialMessagesを含めない。ClaudeProvider.callは従来の provider と結果生成関数を呼び、従来と同じ結果を返す。pnpm validateが通る（648 tests pass）。Review gate
Round 1（全差分）: GO。reviewed head
69e0745316554cb168f2c767e9487fb57359be84、blocker 0 件。Codex（gpt-6-sol medium）と Opus（high）の 2 系統とも 8 観点で blocker なし。pnpm validateと CI（validate / test-node / test-browser）は通過。Non-blocking（P3）:
onSdkMessageにストリームイベントを流してonPartialUsageまで届くかは確かめていない（その経路はclaudePartialUsageの単体テストで確認済み）。Generated with spec-implement-accept skill
🤖 Generated with Claude Code
https://claude.ai/code/session_013YE1FnUCruD4Mtwbjx3nyq