Repository navigation
Fix HTTP run subscription disclosures and Shannon audit findings - #301
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
undefined, and reject malformed or unrepresentable scopes before streaming.run:coalescedevent while preserving the in-process event; treat explicit empty run filters as matching no runs.llms.txt, and accepted ADR-0036. Narrow the documentation checker to maintained docs and examples.Finding dispositions
The archived Shannon run reported zero exploit-confirmed findings and eight static-analysis leads. Source review confirmed four reachable causes under the documented preconditions: coalesced HTTP payload crossing label scopes (SARIF 1–2), auth hooks skipped for an undefined context (3–5), list-scope fallback or missing global stream scope (6–7), and empty filter arrays widening access (8). All four are addressed with regression tests.
PR #300 review candidates LS-1, RB-1, XF-1, EF-1, CV-1, and SIG-1 are addressed. RU-1 was a refactor request without a demonstrated defect; ALT-1 was an external quota condition later cleared; the external dependency-root candidate was refuted because the resolved root was already walked and hashed. The full evidence and dispositions are in the task-directory triage report kept outside the branch diff.
Verification
pnpm validate— pass (32/32 Turbo tasks; audit script 19/19 tests).claude/skills/doc-check/scripts/find-stale.sh— passBase SHA:
2fc40d812f943d19a945d3f8d86a8e1c0d2b4fcdHead SHA:
be61d35e683f225a5da4a5655612006800fdb288Round 1 independent Codex and Opus reviews identified a confirmed P2 interrupt window, now fixed in 5f51218. The follow-up also aligns empty React run filters, updates the scope hook TSDoc, and replaces a vacuous interrupt test with deterministic boundary tests. Round 2 independent review found no blockers; its GO applied to the prior head. Three confirmed P3 follow-ups (test title, cleanup assertions, and unnecessary listeners for an empty authorized stream) were fixed in be61d35. Round 3 reviewed the delta and affected callers at the current head. Codex completed eight perspectives with no new candidates; Opus and an independent Codex verifier found only two nonblocking P3 future-regression test coverage gaps. The exact-head Draft-to-Ready gate reached GO, with all five reported PR checks passing.
Remaining nonblocking review notes
scanStartedmay be set just before the scanner begins, so cleanup can query a workspace that never started. This remains a plausible P3; Shannon's known “No scan found” response is handled quietly, and no material failure was established.