Repository navigation
Recent is one list everywhere; per-app recent is its own submenu - #7
Open
combwizard wants to merge 1 commit into
Open
combwizard wants to merge 1 commit into
combwizard wants to merge 1 commit into
Conversation
Recent ranked folders with a boost for the app the menu was opened over, so Explorer and Directory Opus showed different lists. It now ranks by overall use only. The per-app ranking moves to a second submenu, "Recent in <app>", off by default (Settings > Menu > Show recent folders for this app, showAppRecent). It lists only folders used in that app, ranked by the visits there. Places inside archives, such as tools.zip\bin browsed in Explorer or Opus, are no longer recorded, and ones already in history.json are dropped on load. A path part with an archive extension counts unless it is a real folder.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Recent submenu showed different folders over Explorer and over Directory Opus. It ranked folders with a boost for the app the menu was opened over, keyed by process name, so
exploreranddopuseach pushed their own folders into the top 15.Opus also recorded places inside archives, such as
Downloads\solidcraft-windows-x64-portable.zip\solidcraft-0.40.0-rc.3-windows-x64-portable, and these showed in Recent.Fix
Recent is one list.
FrecencyStore.Topranks by overall use only, so the list is the same in every app and over the tray icon.The per-app ranking is its own submenu, Recent in , under Recent. It is off by default: Settings > Menu > Show recent folders for this app, or
showAppRecentinconfig.json.FrecencyStore.TopInApplists only the folders used in that app, ranked by the visits made there.Places inside archives are not recorded, and ones already in
history.jsonare dropped when it loads. A path part with an archive extension (.zip,.7z,.rar,.isoand other common ones) counts unless it is a real folder. That keeps a folder namedbackup.zip, and still catches a place in an archive that has since been deleted. Only parts with those extensions are checked on disk.The docs are updated:
menu.md(new section Recent folders for this app),settings.md,config.md,how-it-works.md,dialogs.md,troubleshooting.md,building.md, the README and the landing page.Testing
dotnet test: 312 passed. New tests coverTopInApp, the archive rule (archive files, a folder named like one, a deleted archive) and the new submenu inMenuComposer.mkdocs build --strict: passes.history.jsonwith 202 entries, the archive rule drops 31. All of them are archive paths.building.mdhas the steps.