Repository navigation
The ring opens faster: pictures kept between opens and drawn ahead of the first - #210
Merged
Merged
Conversation
… opens and stops resizing slots that keep their size every frame
…layer and fan lines are tested on the rest of their inputs
…e level down a second after the menus load, so the first open finds them
…the expander has filled is not filled again
… plan uses ZBrush's monitor while another program is in front, waits for the first recent lists, is dropped when it fails, and the static layers have room for the click hints
…does, and a Recent fan opened as a ring keeps its items
… the newest: a second load of the menus no longer hides the first load's thread
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ring opens faster, the first time after start as well as every time after, and hover, fans and taps are smoother. What it draws is unchanged, with one exception listed under "Behaviour changes".
What changed
The ring keeps more between opens (
ring.py)The app draws ahead (
radiald.py)Bug fixes found on the way
expand.py,config.Menu.filled). This was on main before this branch.Behaviour changes
radiald.logwhen a warm-up has drawn something.Measured
Medians from one development PC, off screen with the real renderer, 16-slot ring at 150% scaling. Before is main.
Not measured: anything with live ZBrush, the real hook or a pen.
Checks
tools/ring_shots.pyoutput is the same before and after; no docs picture is retaken.tests/test_ring_warm.py,tests/test_auto_order.py,tests/test_tag_ring_colours.py, and the cache tests at the end oftests/test_ring.py.ZORBIT_NO_DOCS=1.Worth a look on a real ZBrush before merging
radiald.loghas aring warm-upline after start.