Repository navigation
Conversation
This was referenced Sep 23, 2026
ericgozzi
added this pull request to stack #60
September 23, 2026 06:23
| asyncio.set_event_loop(self.loop) | ||
|
|
||
| config = uvicorn.Config(self.fastapi_app, host=host, port=port, log_level="warning") | ||
| # Default ws_max_size (16 MiB) is too small for a large uploaded .stkm.json sent as a |
Member
There was a problem hiding this comment.
Don't mention .stkm.json here, just large json files
gonzalocasas
requested changes
Oct 11, 2026
gonzalocasas
left a comment
gonzalocasas
left a comment
Member
There was a problem hiding this comment.
lgtm, with a tiny little change request
uvicorn's default ws_max_size (16 MiB) silently dropped the WebSocket connection with no surfaced error when a large .stkm.json was sent as a single WebSocket text frame (LoadTimberModel.vue's upload path). Raise it to 256 MiB to comfortably cover that path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ericgozzi
force-pushed
the
fix/websocket-max-size
branch
from
October 13, 2026 09:23
c10f5ea to
0b39b56
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ws_max_size(16 MiB) silently dropped the WebSocket connection, with no error shown, when a large.stkm.jsonwas sent as a single text frame (theLoadTimberModel.vueupload path).server.py, which covers that path comfortably.Stacked on #57 (spinner persistence); merge that first.
Test plan
pytest🤖 Generated with Claude Code