Conversation
A picked object wears the pick highlight, with its own material parked until deselection. A material update for it replaced the highlight but left the stale parked material, so deselecting put the old color back until the object was rebuilt (e.g. by moving it). Updates now replace the parked material, and a local edit shows the real material at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes material edits on a picked object being lost when it is deselected.
A picked object wears the pick highlight, with its own material parked in
pickedMaterialuntil deselection. A material update for it (e.g. the backend's echo of a Material toolbar edit) replaced the highlight but left the stale parked material, so deselecting put the old color back - until the object was rebuilt, for example by moving it. This mostly showed on objects added without a material of their own (add_geometry(box)).setMaterialedit shows the object's real material at once instead of leaving it hidden under the highlight.Test plan
tests/viewer_lifecycle.test.ts(fails without the fix: the box falls back to the default#0092d2after deselecting).prettier,lint,typecheck,test,build:app,build:librarypass.compas_threejsApp: the edited color survives deselection.🤖 Generated with Claude Code