Conversation
Polygon renders as a filled face triangulated in its own plane (so concave shapes fill correctly), facing up when horizontal, with its outline. Arc renders as a line sampled between its start and end angles. Both move from "deferred" to "included" in the support matrix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renders COMPAS
PolygonandArc, both previously listed as "deferred" in the support matrix.LineLoop. A horizontal polygon's face always points up, whichever way its points run. A closing point repeating the first is dropped.docs/support-matrix.mdmoves both to "Included".Note:
@gramaziokohler/compas-pb-ts2.0.0 rejects anArcwhosestartAngleorendAngleis exactly 0 (a falsy check in its constructor, also on decode), so such arcs never reach the viewer. Worth fixing upstream; the tests use non-zero angles.Test plan
tests/converter.test.ts: a concave L-shaped polygon (6 vertices, 4 triangles, area 3, normal up) and a quarter arc (all samples on the circle, correct end points).prettier,lint,typecheck,test,build:app,build:librarypass.🤖 Generated with Claude Code