Skip to content

chore: allow Laravel 13 (illuminate ^13) - #1

Merged
jordanpartridge merged 3 commits into
masterfrom
chore/laravel-13
Aug 22, 2026
Merged

chore: allow Laravel 13 (illuminate ^13)#1
jordanpartridge merged 3 commits into
masterfrom
chore/laravel-13

Conversation

@jordanpartridge

Copy link
Copy Markdown
Contributor

Summary

Allow Illuminate 13 so this package installs on Laravel 13 apps.

Test plan

  • composer require on a Laravel 13 app resolves
  • Sentinel / Pest still green on existing matrix

Install-blocker on L13 apps. Spatie package-tools already allows contracts ^13.

@lexi-chief-of-staff lexi-chief-of-staff Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

  • Version constraint update is minimal and scoped to the three illuminate packages plus testbench.
  • No code changes, so no new compatibility surface introduced.
  • Test plan in PR body covers the only real risk (composer resolution on L13).
  • Existing matrix remains intact; no conflicts with current patterns in the repo.

@lexi-chief-of-staff lexi-chief-of-staff Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

  • Version constraints updated cleanly for illuminate ^13 and testbench ^11.
  • pest-plugin allow-plugins addition prevents future install warnings.
  • No code changes; matrix coverage noted in test plan is sufficient for a constraints-only bump.
  • Ready for merge once CI passes on the expanded range.

@jordanpartridge

Copy link
Copy Markdown
Contributor Author

@lexi-chief-of-staff Laravel 13 constraint bump. Please watch this PR and DM Jordan on Mattermost when it looks merge-ready (mergeable, not draft; CI green). Treat Sentinel Gate security-audit red as known transitive CVEs, not a merge blocker, if that is the only failing check. Do not merge.

@lexi-chief-of-staff

Copy link
Copy Markdown

PR status: not merge-ready

  • Checks: Tests (PHP 8.3) failed, PHP CS Fixer & Pint failed, Validate composer.json passed, Tests (PHP 8.2) cancelled.
  • Merge gates: Not mergeable (failing checks + not draft status unknown from checks alone).
  • No Sentinel Gate run visible.

Watching. Will DM on Mattermost + update here once CI is green and mergeable. [from: GitHubPRChecks]

Remove leftover root copies of src files (not autoloaded).
Pint the src tree. Add phpunit.xml + a contract unit test so
Pest no longer dies on a missing config ("--cache-directory").
@jordanpartridge

Copy link
Copy Markdown
Contributor Author

@lexi-chief-of-staff CI fix pushed: Pint on src, phpunit.xml + a contract Pest test, deleted unused root PHP copies. Re-check merge-ready when Pint + Tests (PHP 8.2/8.3) are green. Do not merge until checks pass.

@lexi-chief-of-staff

Copy link
Copy Markdown

Watching PR #1.

Checks just re-triggered on 89a6ad9:

  • PHP CS Fixer & Pint queued
  • Tests (PHP 8.2) queued
  • Tests (PHP 8.3) in_progress
  • Validate composer.json already ✅

Will re-check when the two test runs + Pint finish. No merge until all green.

@lexi-chief-of-staff lexi-chief-of-staff Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

  • composer.json now declares ^11|^12|^13 for illuminate/* and ^9|^10|^11 for testbench; matches the stated goal.
  • Root-level model/contract/service files deleted and reimplemented under src/ with only whitespace and trailing-comma fixes.
  • New phpunit.xml and Pest skeleton added; the contract test exercises the interface but does not yet cover storage or Laravel 13 matrix.
  • .gitignore addition and pest-plugin allow-plugins entry are standard and correct.

No correctness or safety blockers.

@jordanpartridge
jordanpartridge merged commit 13d6c9b into master Aug 22, 2026
4 checks passed
@jordanpartridge
jordanpartridge deleted the chore/laravel-13 branch August 22, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant