Skip to content

feat: add MapLibre map primitive and Sheets integration - #24

Open
yyyyaaa wants to merge 2 commits into
mainfrom
phat/mapcn-integration
Open

feat: add MapLibre map primitive and Sheets integration#24
yyyyaaa wants to merge 2 commits into
mainfrom
phat/mapcn-integration

Conversation

@yyyyaaa

@yyyyaaa yyyyaaa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a MapLibre-backed Constructive map primitive, package exports, theme ownership, third-party notice, and the @constructive/map registry item
  • replace the Sheets Leaflet point picker with a lazy MapLibre editor, optional host geocoder, JSON fallback, and no direct public Nominatim requests
  • add registry and packed-package coverage, documentation, Storybook stories, and tile-free New York demos across documentation surfaces

Verification

  • UI typecheck and test suite: 71 tests passed
  • Blocks typecheck and focused documentation tests: 36 tests passed
  • generated demo source check passed
  • Storybook production build passed
  • live Storybook and Blocks browser smoke passed, including random marker movement
  • git diff check passed

Scoped React audit

React Doctor and manual review found two medium follow-ups: complete keyboard and combobox semantics for the optional Sheets geocoder, and replace the shared render-time deep-style ref mutation and serialization path. The remaining accepted findings are low-impact render and Fast Refresh cleanup.

# Conflicts:
#	apps/blocks/src/app/sitemap.test.ts
#	apps/blocks/src/components/docs/ui-demos.test.tsx
#	apps/blocks/src/lib/base-primitives.test.ts
#	packages/sheets/src/grid/__golden__/display-cases.ts
#	packages/sheets/src/grid/__golden__/parity.harness.ts
#	packages/ui/registry.json
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedmaplibre-gl@​6.3.0971001009970

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm gl-matrix is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/maplibre-gl@6.3.0npm/gl-matrix@3.4.4

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/gl-matrix@3.4.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant