chore(fixtures): bump the @constructive-db fixture modules to the same-scope FK release - #1766
Merged
Merged
Conversation
…e-scope FK release Picks up apps@7.0.0, catalog@6.0.0, routing@8.0.0, routing-platform@7.0.0, the published output of the constructive-db same-scope foreign key fix.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This comment has been minimized.
This comment has been minimized.
routing@8.0.0 / routing-platform@7.0.0 grant to authenticated_client, which is opt-in (admin-users bootstrap --client) and was absent from 6.1.0 / 5.1.0, so every seed.pgpm deploy failed with role "authenticated_client" does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the root
pgpm.jsonfixture pins onto the just-published output of the constructive-db same-scope foreign key fix (constructive-io/constructive-platform#21):No test or fixture changes are needed for the FK change itself. The majors are breaking at the SQL level —
routes.target_*,sites.bucket_id,app_components.component_*and friends now reference the same-scope source tables instead of the sharedcatalog_private.*projection — but__fixtures__/seed/scoped/test-data.sqlalready seeds each routing/apps source row alongside its catalog twin under the same id (and inserts theapps_publicrows afterrouting_public.{apis,domains}), so every constraint is satisfied under either shape andresolve_route()reads the same compiled bindings.One real break, in the bootstrap and not the tests: the new majors are the first to grant to
authenticated_client(routing/…/rls_settings/grants,routing-platform/…/grants/usage) —npm packof 6.1.0/5.1.0 contains zero references to it. That role is opt-in (admin-users bootstrap --client), so with a plainbootstrap --yeseveryseed.pgpmdeploy died atrole "authenticated_client" does not existand took the wholeintegration-graphqlandpg-graphqllanes with it. Added--clientto the three CI bootstrap steps and to the local instructions that mirror them (Makefile,DEVELOPMENT.md, the two setup skills) — matching what constructive-platform's ownAGENTS.mdalready requires of anyone deploying these modules.Verified against the new modules with
pgpm install -W --force:graphql/server-test11/11 suites, 156 tests (includingscoped-routing,fn-routes,express-context,upload) andgraphile/graphile-function-bindings2/2 suites, 22 tests.Note that
pgpm install -W @constructive-db/apps@latestdoes not move an already-installed module — it re-resolved the existing5.1.0pin and leftpgpm.jsonuntouched, so that one line was edited by hand and then verified by a forced reinstall (default_version = '7.0.0').Link to Devin session: https://app.devin.ai/sessions/d1f8e59e2aeb44bcb6dbeb0edd1145c6
Requested by: @pyramation