feat(agentic): a dsh adapter beside the pi one - #1769
Merged
Conversation
@agentic-kit/dsh binds the neutral HarnessTools to DeepSeek Harness (toDshTool, a zod->dsh JSON Schema narrowing, a plugin wiring the confirm gate to tools/pre-execute) and normalizes dsh session events into neutral transcript events. The Constructive gate deps move into db-tools so both adapters share them.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The second adapter, which is the only real proof the neutral seam works:
@agentic-kit/dshbinds the same@agentic-kit/db-toolsinto DeepSeek Harness and reads its transcripts, without a single dsh import anywhere upstream of the package.Three seams, mirroring the pi adapter:
Judgment calls worth knowing:
@deepseek-ai/*dependency. The package declares dsh's contact surface structurally (DshToolDefinition,DshPlugin,DshPreToolDecision, …), so a host that already has dsh installed passes its objects in and nothing here pins a pre-release rc — and no ESM leaks into our dual CJS/ESM builds.HarnessAdapter/HarnessRunimplementation. dsh exposes no stable start/resume lifecycle to implement it against, so this stops at the three seams that do exist rather than inventing methods.convertDshParameters()returns{ parameters, dropped }: disjoint unions becomeoneOf(dsh's spelling ofanyOf), overlapping object unions widen to unconstrained and are listed indropped, along withformat/minimum/minItems. Nothing is silently weakened, becauseexecutestill runstool.parameters.parse(args)before the tool sees anything.$refthrows rather than shipping a schema dsh can't resolve.tools/pre-executeasks dsh's approval service and treats onlyallowed-onceas consent; with no approval service available a gated tool is denied rather than auto-run.Along the way, the Constructive-specific gate resolvers move out of the pi adapter into
db-toolsasconstructiveGateDeps(), so both adapters answer "is this project runnable / is there a data token / what would this template copy" from one place instead of two copies.Link to Devin session: https://app.devin.ai/sessions/2d292e43fd2e4f34bb84605b5aa2a250
Requested by: @pyramation