sync: port the infrastructure-surface module tables from constructive-db - #122
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the module-registry side of https://github.com/constructive-io/constructive-db/pull/3170 (all 59 checks green) — the source of truth for these tables — so the two trees stay identical. Bundles regenerated with
pgpm package;pgpm test-packages --full-cyclepasses (deploy → verify → revert, all 29 modules).http_route_moduleis deleted (table + plan entry + revert/verify). Generated HTTP routes are gone; route resolution isrouting_public.resolve_routeover the catalog, so nothing configures a route plane any more.catalog_modulegainsimages_table_id/images_table_name— the catalog grows animageskind, so a scope's published images are readable down-frame the wayfunctionsalready is.repository_modulegainssearch jsonb— per-install search/embedding config (dimensions,has_chunks, embedding model/provider) the generator turns intoSearchFullText/SearchVector/ProcessChunksnodes onproposals,proposal_comments,proposal_reviews,repositories.entity_fk_table_id/actor_fk_table_id. Those knobs existed to point the entity/actor columns at an arbitrary table; the columns now carryAuthzEntityMembershipSELECT policies keyed onentity_idinstead, so nothing needs a configurable FK target.function_resolution.image_catalog_row(name)— new reader, the images twin ofbucket_catalog_row: nearest reachable frame wins.Test fixtures that
INSERT INTO metaschema_modules_public.catalog_moduleneededimages_table_idadded: it isNOT NULL DEFAULT uuid_nil()with a FK tometaschema_public.table(matching its sibling columns), so an omitted column fails the FK on the nil default rather than being ignored.Link to Devin session: https://app.devin.ai/sessions/3bf7558531a74216bb1d68b8f04f1519
Requested by: @pyramation