feat(desktop): OSC debugging moves into Output, and looks stay in the show UI - #119
Merged
Conversation
… show UI Nova and Traffic leave the outer shell: looks belong to the artist UI the show serves, and packet capture is terminal work (tools/traffic stays). OSC debugging becomes Output's Advanced tab, next to the target it debugs. Also default the artist UI's parameters panel to the right of the grid rather than under it, remembered across reloads.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three sidebar destinations disappear, one gains a tab.
Routelosesnova,oscandtraffic, so those hashes are no longer routes at all:nova:*IPC that backed it are gone.Output → Advanced: the question it answers ("why is nothing lighting up?") is a question about Output's target, soOscRouteis nowOscPanel, rendered byOutputRouteinside a tab. The panel only mounts when that tab is opened, so it still probes nothing until asked.tools/trafficremains as terminal tooling. Its renderer route, main-process module and IPC surface (traffic:*, and theTraffic*types) are removed with it; the desktop app no longer looks for Wireshark at all.OutputRoutegainsstatusbecause the panel needs it to warn when the project being debugged isn't the one running:Unrelated but in the same breath, from a request while this was in flight: the artist UI's parameters panel now defaults to the right of the grid instead of underneath it, and the choice is remembered (
wavegrid-panel-layout) rather than resetting tobottomeach load.Docs that pointed at
Advanced → OSCor the Traffic tab now point atOutput → Advancedor the terminal.Link to Devin session: https://app.devin.ai/sessions/ec43152136134467a853ec0bbf783ea9
Requested by: @pyramation