fix(frontend): order the roster by name - #3199
Conversation
The People roster grid defaults to the "furthest behind" order but never passed showIssues, so the standing chip, the "worst:" line and the Person sort arrow stayed hidden — the roster read as unsorted. Wire the team-state view to the standing facet. The legend was static as well, promising a Bottom 25% red that the Rewards and Critical focus modes never paint; it now names only the standings the active focus still paints. Signed-off-by: hello1101n <hello1101n@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change makes the member legend respond to ChangesFocus-aware member legend
Team state member grid
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The Members grid now shows focus-appropriate standing legends and issue indicators in the team-state view, with coverage for focus filtering and peer-standing labels. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
This reverts commit 6317527. Signed-off-by: hello1101n <hello1101n@users.noreply.github.com>
The People roster's members grid opened on the "furthest behind" order even where nothing on screen named it: no standing chip, and the Person header offers only a name toggle. Beside an alphabetical org tree the rows read as unordered. Default to name order whenever the standing facet is off. Views that do show the facet — AI & Cost, the group drilldowns — keep behind-first. Signed-off-by: hello1101n <hello1101n@users.noreply.github.com>
|
Follow-up on the dead facet this order came from: #3201. |
Why. The People roster's Members list opens in an order nothing on screen explains — behind-peers first — while the org tree next to it is A→Z. Rows read as unordered.
What changed. The grid defaults to name order whenever the standing facet is off, which is exactly the roster: no chip names a standing, and the Person header offers only a name toggle. Views that do show the facet — AI & Cost, the group drilldowns — keep behind-first.
Screenshots. People roster on the MSW mock roster, same data either side.
Verified.
pnpm test(2357),pnpm lint,pnpm typecheck— green. Screenshots frompnpm devon the mock roster, no deployed data.