Skip to content

make sure parameter default value does not contain \n #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShemTovYosef merged 1 commit into from
Oct 20, 2026
Merged

make sure parameter default value does not contain \n #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/ctm_python_client/ext/autogen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,15 @@ class AIPluginCustomDefinition:
comments: typing.List[str]


def normalize_default(default):
if not isinstance(default, str) or '\n' not in default:
return default
without_trailing_newlines = default.rstrip('\n')
if '\n' not in without_trailing_newlines and without_trailing_newlines.strip():
return without_trailing_newlines
return ''


def create_ai_custom_definitions(ai_plugin: Plugin) -> typing.Tuple[AIPluginCustomDefinition, AIPluginCustomDefinition]:
plugin_name = ai_plugin.job_name.split(':')[-1]
plugin_cp_name = ai_plugin.cp_name.split(':')[-1]
Expand Down Expand Up @@ -92,7 +101,7 @@ def create_ai_custom_definitions(ai_plugin: Plugin) -> typing.Tuple[AIPluginCust

domain_name = v.get('DomainName')
if domain_name in ai_plugin.job_definition['Defaults']:
default = ai_plugin.job_definition['Defaults'][domain_name]
default = normalize_default(ai_plugin.job_definition['Defaults'][domain_name])

job['optional_properties'].append((
domain_name.split(r'%%UCM-')[1].lower(),
Expand All @@ -115,7 +124,7 @@ def create_ai_custom_definitions(ai_plugin: Plugin) -> typing.Tuple[AIPluginCust

domain_name = v.get('DomainName')
if domain_name in ai_plugin.cp_definition['Defaults']:
default = ai_plugin.cp_definition['Defaults'][domain_name]
default = normalize_default(ai_plugin.cp_definition['Defaults'][domain_name])

cp['optional_properties'].append((
domain_name.lower(),
Expand Down
Loading