Repository navigation
Filter onComplete callbacks by result status - #237
Merged
Merged
Conversation
commit: |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
reeceyang
approved these changes
Sep 11, 2026
|
|
||
| describe("enqueue", () => { | ||
| it.each([false, true])( | ||
| "accepts legacy, empty, and populated callback exclusions (batch: %s)", |
Contributor
There was a problem hiding this comment.
what is a legacy callback exclusion? excludeKinds: undefined?
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers who only need failure or cancellation handling can now reuse one
onCompletehandler withonCompleteExcludeKinds: ["success"].This is an alternative to #231 (
onFailure) and #236 (onCancel), based on current main now that their shared test cleanup has landed. It does not depend on either feature PR.Mutation-only transactional success is a separate stacked change in #238, and for queries in #239.