Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GitHub's /releases/latest/download lookup uses the exact asset filename, so versioned archives cannot be linked from docs without updating them each release. Co-authored-by: Cursor <cursoragent@cursor.com>
b12d8ac to
e5d7ae7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b12d8ac595
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [macOS Intel](https://github.com/coralogix/cx-cli/releases/latest/download/cx-x86_64-apple-darwin.tar.gz) | ||
| - [macOS Apple silicon](https://github.com/coralogix/cx-cli/releases/latest/download/cx-aarch64-apple-darwin.tar.gz) | ||
| - [Linux x86_64](https://github.com/coralogix/cx-cli/releases/latest/download/cx-x86_64-unknown-linux-musl.tar.gz) | ||
| - [Linux aarch64](https://github.com/coralogix/cx-cli/releases/latest/download/cx-aarch64-unknown-linux-musl.tar.gz) | ||
| - [Windows](https://github.com/coralogix/cx-cli/releases/latest/download/cx-x86_64-pc-windows-msvc.zip) |
There was a problem hiding this comment.
Backfill stable assets before publishing direct links
If these docs deploy before the next tagged release, the five new archive links return 404 because the Package steps in .github/workflows/release.yml create the unversioned assets only for future workflow runs, while the existing latest release was not backfilled. This immediately regresses the previously working Releases-page instructions, including the primary Windows download path; upload these aliases to the current release before publishing the links, or retain the old links until a release containing them becomes latest.
Useful? React with 👍 / 👎.
Context
Docs and install instructions cannot permalink a specific GitHub Release binary, because artifacts are named
cx-<version>-<target>. GitHub's/releases/latest/download/<filename>lookup requires that exact filename on the newest non-prerelease. This change attaches a second, unversioned copy of each archive so those URLs stay valid across versions.Linked Issues
N/A — requested as a docs/release-workflow improvement, no ticket.
Design
The existing Release workflow still builds and uploads versioned archives (
cx-0.1.24-x86_64-apple-darwin.tar.gz, etc.). After packaging, it copies each archive tocx-<target>.tar.gz/.zip.action-gh-releasealready uploadsartifacts/*, and checksum generation already globscx-*, so both names land on the GitHub Release and inchecksums-sha256.txt. Docs point at/releases/latest/download/cx-<target>.*. Homebrew, crates.io, andinstall.shkeep using versioned names/tags.Key Decisions
latestgit tag. Renaming would break Homebrew pins andinstall.sh; alatesttag fightsverify-version(tag must match Cargo.toml) and git history.install.shversion-resolved soCX_VERSION=pinning still works. Unversioned checksum lines are extra; looking up the full versioned filename does not collide.Changes
/releases/latest/download/...instead ofcx-<version>-...on the releases index.Testing
cx-*.v0.1.24GitHub Release.Risks & Rollout
Additive only: existing versioned asset names, Homebrew,
cargo install, andinstall.share unchanged. Permalink URLs 404 until unversioned files exist on the current latest release — either a one-offgh release uploadtov0.1.24, or the next tagged release after this merges. Rollback is revert of this PR (future releases stop attaching the extra names; already-uploaded assets on an old tag remain).Out of Scope / Follow-ups
v0.1.24release (gh release upload; do not re-run the full Release workflow, it wouldcargo publishagain).install.shto unversioned/latest/downloadURLs.Made with Cursor