Drop use of openat-ext, Rust std now has efficient std::io::copy - #781
Merged
Merged
Conversation
sohankunkerkar
approved these changes
Feb 15, 2022
bgilbert
reviewed
Feb 15, 2022
bgilbert
left a comment
bgilbert
left a comment
Contributor
There was a problem hiding this comment.
Awesome, thanks!
The upstream changes landed in 1.50.0, so this applies to every Rust version back to our 1.51.0 MSRV.
Member
Author
|
Also xref coreos/openat-ext#43 |
cgwalters
force-pushed
the
drop-openat-ext
branch
from
February 15, 2022 17:58
a5b8f02 to
9571863
Compare
jlebon
approved these changes
Feb 15, 2022
jlebon
enabled auto-merge
February 15, 2022 18:58
bgilbert
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#75272