Repository navigation
firecracker: the handler-exit error carries the handler's log - #1785
Merged
Merged
Conversation
A post-copy restore whose uffd handler exits before the load failed with "uffd handler exited before the load (exit status: 1)". The reason is only in the handler's log in the jail directory, which a failed restore removes. The two-host teleport tests fail this way now and then, and the CI log cannot say why. The error now ends with the tail of `uffd-handler.log`. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HNhpmz4QPYaVCE7tFna54D
The kernel's partition scan reads the start of a new ublk device. On newer kernels it runs in a work item, so the read can arrive after the test's first guest read, and the source records it as read cold. The test then saw chunks [3, 0] where it expected [3]. The test now leaves the first chunk out of the comparison; chunks 1 and up still prove that the copy's stream is not recorded. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HNhpmz4QPYaVCE7tFna54D
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HNhpmz4QPYaVCE7tFna54D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A post-copy restore whose uffd handler exits before the load fails with
uffd handler exited before the load (exit status: 1). The reason is only in the handler's log in the jail directory, and a failed restore removes that directory.The two-host teleport tests in the Firecracker root lane fail this way now and then, on different tests in different runs, and the CI log cannot say why. The error now ends with the tail of
uffd-handler.log, so the next failure names its cause. This PR does not fix that failure.Test plan
cargo fmt --check,cargo clippy --target aarch64-unknown-linux-musl -p engram-sandbox-firecracker -- -D warnings🤖 Generated with Claude Code
https://claude.ai/code/session_01HNhpmz4QPYaVCE7tFna54D