Skip to content

GitHub client works on Jackson 2.21 (merge upstream 1.330) - #38

Closed
akwirick wants to merge 596 commits into
mainfrom
aw/jackson-2-21-naming
Closed

akwirick wants to merge 596 commits into
mainfrom
aw/jackson-2-21-naming

Conversation

@akwirick

@akwirick akwirick commented Nov 3, 2026

Copy link
Copy Markdown

Changes:

  • Merged upstream github-api 1.330 (fork was on 1.313), fixing the NoSuchFieldError for PropertyNamingStrategy.SNAKE_CASE on Jackson 2.20+
  • Kept every Cortex patch (code and secret scanning, release/commit query builders, content builder fields, base-URL user lookups); japicmp shows 1.331 is binary-compatible with 1.329
  • Bumped Jackson to 2.21.8 (brain-backend's version) and okhttp, commons-lang3 and commons-io to upstream's patched versions; version 1.331, since PR Jackson 2.22 compatibility: replace removed PropertyNamingStrategy.SNAKE_CASE #37's branch already published 1.330
  • Gated deploy to pushes on main, so pull request runs no longer publish to GitHub Packages
  • Fixed anonymous contributors requesting /users/null, and moved the Cortex test recordings to the vnd.github+json Accept header
  • Skipped upstream 2.0 (major, API breaks) and its Maven Central release workflows

Related: https://github.com/cortexapps/brain-backend/pull/19193, supersedes #37
Publishing: merging to main publishes 1.331 to GitHub Packages through the deploy job.

Session: kotlin-vs-ts-dbos-rewrite (3c067139) · Worktree: github-api/jackson-2-21

🤖 Generated with Claude Code

gsmet and others added 30 commits March 11, 2024 16:41
…hub4j#1810)

* Make sure we refresh the PRs with the PR API (and not the issues API)

When a PR was loaded from a search, the refresh() method was reloading
information from the issues API, which would lead to some information
not being refreshed properly, typically the mergeable state.

Related to hub4j#1779 (comment)

* Update GHPullRequestTest.java

* Update GHPullRequestTest.java

* Update GHPullRequestTest.java

* Update GHPullRequestTest.java

---------

Co-authored-by: Liam Newman <bitwiseman@gmail.com>
…j#1690)

* Do not populate repo list in case of installation:deleted event

* Implement discussed way to handle the situation

* Fix codestyle

* Fix build (I hope?)

* Update GHEventPayload.java

* Update GHEventPayload.java

* Fix missing import

* Update src/test/java/org/kohsuke/github/GHEventPayloadTest.java

* Update src/test/java/org/kohsuke/github/GHEventPayloadTest.java

* Apply suggestions from code review

* Update test data

---------

Co-authored-by: Liam Newman <bitwiseman@gmail.com>
)

* Implement ServiceDownException for case GitHub's API is down

* Update src/main/java/org/kohsuke/github/GitHubConnectorResponseErrorHandler.java

* Update src/main/java/org/kohsuke/github/GitHubConnectorResponseErrorHandler.java

* Apply suggestions from code review

* Update src/main/java/org/kohsuke/github/ServiceDownException.java

---------

Co-authored-by: Liam Newman <bitwiseman@gmail.com>
* Support team, team_add, member and membership payloads

I removed/updated some outdated files that were apparently added in the
hope of someone implementing the payloads but I preferred to start fresh
with new updated payloads.

I did a few adjustments to some existing enums to make sure we don't
have an error when a payload arrives with an unknown value. I used the
same pattern we decided to implement some time ago.

* Apply suggestions from code review

* Update src/main/java/org/kohsuke/github/GHTeamChanges.java

---------

Co-authored-by: Liam Newman <bitwiseman@gmail.com>
hub4j#1817)

* Add Support for Retrieving Template Repository Information for a Repository

Spotless apply

Applied spotless

* doc: Improvement javadoc

* Resolve comments on pull-request
Prepare release (bitwiseman): github-api-1.320
Unfortunately, things are not consistent between added and edited.

added provide a permission of some sort and a role name (sometimes...)
edited only provides permission and it's not exactly the same ones

For now, I think we need to return strings to avoid issues until GitHub
adjusts the API.
Be a lot more flexible as for GHMemberChanges values
Prepare release (bitwiseman): github-api-1.321
Co-Authored-By: Liam Newman <bitwiseman@gmail.com>
Fix visibility of getters in GHRequestedAction
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.4.1 to 3.6.3.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.4.1...maven-javadoc-plugin-3.6.3)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.awaitility:awaitility](https://github.com/awaitility/awaitility) from 4.2.0 to 4.2.1.
- [Changelog](https://github.com/awaitility/awaitility/blob/master/changelog.txt)
- [Commits](awaitility/awaitility@awaitility-4.2.0...awaitility-4.2.1)

---
updated-dependencies:
- dependency-name: org.awaitility:awaitility
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…decov/codecov-action-4.1.1

Chore(deps): Bump codecov/codecov-action from 4.1.0 to 4.1.1
…maven.plugins-maven-javadoc-plugin-3.6.3

Chore(deps): Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.4.1 to 3.6.3
…ity-awaitility-4.2.1

Chore(deps-dev): Bump org.awaitility:awaitility from 4.2.0 to 4.2.1
Add support to list Security Managers in a GitHub Organization.
bitwiseman and others added 25 commits January 24, 2025 23:18
Prepare release (bitwiseman): github-api-2.0.0-alpha-3
Prepare release (bitwiseman): github-api-1.327
…8.0 (hub4j#2114)

Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-lang3
  dependency-version: 3.18.0
  dependency-type: direct:production
Prepare release (bitwiseman): github-api-1.328
Prepare release (bitwiseman): github-api-1.329
This change requires Jackson  or later.  This change is technically breaking but 5+ years old.

FasterXML/jackson-databind@9f97baa

Fixes hub4j#2137
Changes:
- Merged hub4j/github-api 1.330 (the fork was on 1.313), which reads PropertyNamingStrategies.SNAKE_CASE instead of the field Jackson 2.20 removed
- Kept the Cortex patches: code and secret scanning alerts, release and commit query builders, content builder fields, workflow run created filter, base-URL user lookups
- Bumped the Jackson BOM to 2.21.8 to match brain-backend, and the version to 1.331 (1.330 was already published from PR #37's branch)
- Restored GitHub Packages publishing and gated the deploy job to pushes on main, so pull request runs can't publish a version
- Skipped anonymous contributors in GHPerson.populate instead of requesting /users/null
- Updated the Cortex test recordings to the vnd.github+json Accept header upstream now sends
- Skipped japicmp (old releases are only in GitHub Packages) and dropped upstream's Maven Central release workflows and codecov upload

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Changes:
- Pointed AotIntegrationTest at Spring AOT output under the cortexapps-github-api artifactId, where process-test-aot writes it
- Added the code scanning, secret scanning, release query and content builder classes to reflect-config.json and serialization-config.json, matching upstream's full registration

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Changes:
- Excluded 7 Cortex-only classes from jacoco's per-class method check, which upstream's 1.330 pom added; their tests have no usable recordings (the code scanning fixtures hold no dismissed alerts, so the get and instance tests skip), and new fixtures need live access to the recorded repo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@akwirick
akwirick requested review from a team and quicksnap November 3, 2026 19:05
@quicksnap
quicksnap removed their request for review November 4, 2026 00:20
@akwirick akwirick closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.