Repository navigation
fix(composer): allow + in the query so :+1 suggests 👍 - #926
Draft
pasqualevitiello wants to merge 2 commits into
Draft
pasqualevitiello wants to merge 2 commits into
pasqualevitiello wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Add `+` to the characters a Composer query may contain, both before the caret and in the suffix that completes the word at the caret. The pattern is shared by every trigger, so `@a+b` now stays an open mention query too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pasqualevitiello
force-pushed
the
fix/composer-query-allow-plus
branch
from
November 18, 2026 12:42
a7b6a28 to
2fe2220
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Typing
:+1in a Composer with a:emoji trigger should suggest 👍, but+isn't allowed in a query, so the popup never opens. This adds+to both character classes ingetComposerQuery:/^[\p{L}\p{M}\p{N}\p{Zs}_.’'+-]*$/u/^[\p{L}\p{M}\p{N}_.’'+-]*/u-stays last in each class, so it's still a literal.calcom/cal keeps a synced copy of the Composer, and that copy already allows
+. Making the same change here means the next sync won't drop it.Side effect
The pattern is shared by every trigger. So
@a+bnow keeps the mention popup open (with no results) instead of closing it. calcom/cal already behaves this way.Changes
apps/ui/registry/default/lib/composer-query.ts: the registry sourcepackages/ui/src/lib/composer-query.ts: the synced package copy (same content)apps/ui/public/r/composer-query.json: rebuilt withregistry:build🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.