Skip to content

gradle 9.8 DependencyManagementServices api change #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
countableSet merged 3 commits into from
Oct 7, 2026
Merged

gradle 9.8 DependencyManagementServices api change #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c0389d
gradle 9.8 DependencyManagementServices api change
countableSet Oct 7, 2026
67a6188
drop java 11/17 for 21/25
countableSet Oct 7, 2026
2a834a7
add DisableCachingByDefault annotation
countableSet Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
build:
strategy:
matrix:
java: ['11', '17', '21']
java: ['21', '25']

runs-on: ubuntu-latest

Expand Down
6 changes: 3 additions & 3 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ gradlePlugin {
}

java {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_21
targetCompatibility = JavaVersion.VERSION_21
}

kotlin {
compilerOptions {
jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_11)
jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_21)
}
}

Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
2 changes: 1 addition & 1 deletion gradlew
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/main/kotlin/dev/poolside/gradle/semanticversion/SemanticVersionTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.TaskAction
import org.gradle.api.tasks.TaskCollection
import org.gradle.work.DisableCachingByDefault
import org.w3c.dom.Element
import javax.inject.Inject

@DisableCachingByDefault(because = "in case a version was uploaded, should always check")
abstract class SemanticVersionTask : DefaultTask() {

private val versionRegex = "^\\d+\\.\\d+\$".toRegex()
Expand Down
5 changes: 3 additions & 2 deletions src/main/kotlin/dev/poolside/gradle/semanticversion/VersionFinder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
package dev.poolside.gradle.semanticversion

import org.gradle.api.internal.artifacts.DependencyManagementParameters
import org.gradle.api.internal.artifacts.DependencyManagementServices
import org.gradle.api.internal.artifacts.ivyservice.ivyresolve.ConfiguredModuleComponentRepository
import org.gradle.api.internal.artifacts.ivyservice.ivyresolve.strategy.DefaultVersionComparator
import org.gradle.api.internal.artifacts.ivyservice.ivyresolve.strategy.Version
import org.gradle.api.internal.artifacts.ivyservice.ivyresolve.strategy.VersionParser
import org.gradle.api.internal.initialization.StandaloneDomainObjectContext
import org.gradle.api.logging.Logger
import org.gradle.api.publish.maven.MavenPublication
import org.gradle.internal.Describables
import org.gradle.internal.component.external.model.DefaultModuleComponentSelector
import org.gradle.internal.component.model.DefaultComponentOverrideMetadata
import org.gradle.internal.resolve.result.DefaultBuildableModuleVersionListingResolveResult
Expand Down Expand Up @@ -48,7 +49,7 @@ object VersionFinder {
val remote = resolver.remoteAccess
val local = resolver.localAccess

val handler = dependencyService.newDetachedResolver(StandaloneDomainObjectContext.ANONYMOUS).dependencyHandler
val handler = dependencyService.newDetachedResolver(DependencyManagementParameters(Describables.of("ANONYMOUS"), "", false, false, false)).dependencyHandler
val dep = handler.create(group = publication.groupId, name = publication.artifactId, version = versionSearch)
val selector = DefaultModuleComponentSelector.newSelector(dep.module, dep.versionConstraint)

Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/dev/poolside/gradle/semanticversion/SemanticVersionPluginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class SemanticVersionPluginTest {
companion object {
@JvmStatic
private fun gradleVersions(): Stream<Arguments> = Stream.of(
Arguments.of("8.13"),
Arguments.of("9.8.0"),
)
}

Expand Down
Loading