services: Redact account names from sync security events - #1333
Open
pbzin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The event concatenated an
Accountobject directly, implicitly callingAccount.toString(). That representation includes the complete account name andcan expose email addresses in the
eventslog buffer before the first unlock.Use the framework's canonical
Account.toSafeString()representation instead.It masks letters and digits in the account name while preserving useful
diagnostic context.
Validation
frameworks/base7581a03c7356git diff --checkAccount.toSafeString()masks account-name letters and digits viaAccount.toSafeName()Runtime confirmation requires a build containing this change.