Skip to content

Determine how best to remove the 24px margin from default page template #200

Description

@brylie

Currently, the default page template has a container class that adds 24px of the bottom margin. This causes an empty white bar to appear between the page content and the footer.

image

We added the content class with the idea that it would cause typical HTML elements to behave as expected since Bulma contains a minireset.css that removes HTML default styles like margin and padding.

It is worth considering that our page template already defines main-content and entry-page-content elements that may make the Bulma content class unnecessary in that context.

image

Task

  • determine origin of main-content and entry-page-content classes
  • determine how best to remove the 24px bottom margin from the page template(s)
  • ensure that default HTML elements from the Gutenberg editor still render as expected

Activity

  1. charlesjman commented on Oct 9, 2022

    @charlesjman
  2. JeffyDave commented on Oct 11, 2022

    @JeffyDave
  3. JeffyDave commented on Oct 13, 2022

    @JeffyDave
  4. Joyshah62 commented on Mar 5, 2023

    @Joyshah62
  5. hadeer-khaled commented on Mar 9, 2023

    @hadeer-khaled
  6. added
    💻 aspect: codeConcerns the software code in the repository
    🕹 aspect: interfaceConcerns end-users' experience with the software
    and removed
    help wantedOpen to participation from the community
    on Mar 10, 2023
  7. possumbilities commented on Mar 10, 2023

    @possumbilities
    Contributor

    I'm moving this to blocked since newer advancements in Vocabulary and the newer CreativeCommons.org prototype may render this issue moot.

    Will close later after I've dug in a bit more if warranted.

  8. moved this from Triage to Backlog in possumbilitieson Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions