Repository navigation
Conversation
…c signature and verify it strictly
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Do not merge, tag or release without Gustavo's OK.
Problem: the published
corp-v0.2.6KeepMind.Corp-0.2.6-arm64.dmg, installed on macos-latest, failsspctl --assesswithcode has no resources but signature indicates they must be present. The bundle seal is inconsistent: only part of the bundle is ad-hoc signed, and resources and Info.plist change afterwards. Real users can see "app is damaged". Evidence: https://github.com/criptogus/keepmind/actions/runs/43621824757 (artifactinstall-smoke-macos-latest,corp-spctl.log).Fix
electron-builder.corp.yml:mac.identity: null+afterSign: scripts/mac-adhoc-sign.cjs.scripts/mac-adhoc-sign.cjs(macOS only, a no-op elsewhere) does three things:codesign --force --deep --sign -on the wholeKeepMind Corp.app;codesign --verify --deep --strict --verbose=2, which fails the build on error;codesign -dv.--mac --dir. In app-builder-lib 25.1.8,signAppreturns true even withidentity: null, soafterSignruns after every plist and resource change.src/main/store.tswarns that re-signing can orphan secrets sealed through safeStorage/keychain. Corp already shipped with an (inconsistent) ad-hoc signature, so the risk there doesn't change.installed-apps.ymlruns on this PR because it toucheselectron-builder*.yml. It builds Corp with--mac --diron macos-latest, so the hook's verification runs there.Tests:
tests/mac-adhoc-sign.test.ts(7, child_process mocked) checks the path, args, that verify runs, the non-darwin skip, the failure on a bad verify, and the config wiring. The local vitest run (mac-adhoc-sign + release-artifact-names + release-gates) gave 21/21; typecheck passed.Real validation on a macOS dmg/zip build: separate test branch
test/0.2.7-package-dryrun-1411(prep 0.2.7 + this fix), no publish.Open: the app is still not notarized, so Gatekeeper still warns. The PR only removes the "damaged" state; the first-launch flow from the docs PR is still needed.