fix: main is red, support2 registered without staging/status entries - #360
Merged
Conversation
sebasmos
added a commit
that referenced
this pull request
Aug 4, 2026
#360) 41b85e9 merged #354, which added support2 to registry.REGISTRY but not to staging.SOURCES or status.STATUS. Two tests assert that every registered adapter appears in both, so main has been failing since that merge: tests/test_staging.py::test_every_registered_dataset_has_a_source_entry tests/test_datasets.py::test_dataset_status_covers_registered_adapters Added both entries. The status entry records the truth rather than flattering it: implementation only, solo/cascade/plausibility/referee all pending, with the real run tracked on #297. That keeps the readiness report honest under the real-data rule instead of letting a registered adapter look staged. This is the same failure mode that is still latent on #352 and #249, both of which register an adapter with no SOURCES entry. Flagged on both. 869 passed, 7 skipped, ruff clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f4dd74fmerged #354, which registerssupport2inregistry.REGISTRYbut adds nostaging.SOURCESorstatus.STATUSentry. Two tests assert every registered adapter appears in both, so main has been failing since that merge:Adds both. The status entry records the truth rather than flattering it: implementation only, solo/cascade/plausibility/referee pending, real run tracked on #297. A registered adapter should not read as staged.
Same failure mode is still latent on #352 and #249, which both register an adapter with no
SOURCESentry. Flagged on both.869 passed, 7 skipped, ruff clean. Merging straight away since a red
mainblocks every other branch.