Conversation
Signed-off-by: Radek Barto艌 <radek.barton@microsoft.com>
Extend the digest-pinned Cygwin cross-compiler check to assemble the inline ARM64 __getreent implementation used by newlib. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
OLD ARM64 POC - REFERENCE ONLY
Do not merge. Do not use as a PR base. Do not add to a new stack. Do not consume its build artifacts.
vNext epoch:
2026-08-31-v1Classification:
POC-SUPERSEDEDReplacement:
pendingSummary
e97c157432985faa5a26a900a8dfb7a388a74857so__getreent()andcygloadobtain the stack base from AArch64x18aarch64-pc-cygwincompiler check to assemble the affected inline__getreent()pathaarch64-pc-cygwintarget spellingStack
This PR is intentionally based on
crutkas-fix-aarch64-configure-blocker, the head branch of upstream draft PR msys2/msys2-runtime#359. It will be retargeted/submitted upstream after PR msys2#359; PR msys2#359 is unchanged.Validation
e97c1574__getreentchecknewlib/libm/math/k_standard.csuccessfully and reaches the next blocker:newlib/libm/ld/e_acoshl.c:41:2: error: #error "Unsupported long double format"Branch drift
The cherry-pick applied without conflicts. Existing MSYS2-specific
cygload.ccDLL naming remains unchanged; only the accepted ARM64 stack-base hunk was added. The later non-contiguous signal/SEH series beginning aroundf38c75ais deliberately excluded.