Repository navigation
Catch ABIEventNotFound for an undefined contract event - #94
Merged
Merged
Conversation
web3 7 renamed ABIEventFunctionNotFound to ABIEventNotFound, so eth contract list_events with an event the ABI does not define stopped with an AttributeError instead of saying so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth contract list_eventswith an event the contract's ABI does not define prints "The event is not defined" and returns 1, instead of stopping withAttributeError: module 'web3.exceptions' has no attribute 'ABIEventFunctionNotFound'.web3.exceptions.ABIEventNotFound, the name web3 uses from 7.0 on; setup.cfg requiresweb3>=7.15.0.Test plan
Event.logs()for an undefined event, offline with a mocked config and endpoint and the bundled ERC-20 ABI, on web3 7.15.0 and 8.0.0: crashes on main, returns 1 with the message on this branch🤖 Generated with Claude Code