Adds Reporting for Steam Failed Trades - #411
Merged
Merged
Conversation
It's possible for a Steam trade to hit status 4 (failed) upon offer acceptance. This PR will push notary proofs if the related trade is for a CSFloat sale, allowing the platform to gracefully handle it. Ref CSF-1701
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a9cf8c. Configure here.
GODrums
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It's possible for a Steam trade to hit status 4 (failed) upon offer acceptance.
This PR will push notary proofs if the related trade is for a CSFloat sale, allowing the platform to gracefully handle it.
Ref CSF-1701
Note
Medium Risk
Changes trade verification and notary submission for pending CSFloat sales; failures are mitigated by feature flags and the same backoff used for rollback proofs, but incorrect matching could affect trade state handling.
Overview
Adds detection and reporting when a Steam trade reaches failed status while a related CSFloat sale is still pending with an active offer.
The periodic CSFloat trade ping now runs
pingFailedTradesafter trade history is fetched.findFailedTradeslinks failed Steam history entries to pending trades by asset ID and counterparty, skipping trades already marked withsteam_trade_failed_idor with an accepted offer. When background notary rollback is enabled, it submits proofs through the existingproveTradesInBackgroundpath (with the same 60-minute backoff on proof failure).Trade history fetching now requests and retains failed entries (
includeFailedon the Steam API, status filter, andinclude_failed: trueon notary prove requests).SlimTradegains optionalsteam_trade_failed_idfor deduplication. Unit tests cover the matching rules.Reviewed by Cursor Bugbot for commit ad8c647. Bugbot is set up for automated code reviews on this repo. Configure here.