feat(market): open listings in the skincraft 3d viewer on the market beta - #415
Open
ykns3 wants to merge 17 commits into
Open
feat(market): open listings in the skincraft 3d viewer on the market beta#415ykns3 wants to merge 17 commits into
ykns3 wants to merge 17 commits into
Conversation
…beta Adds a View in 3D launcher to every listing card in the market beta grid and gives the viewer a listing-details panel (name, wear bar, pattern, name tag, accessories, price with a native buy handoff, restrictions, and description) with prev/next navigation that pages through listings via steam's own infinite-scroll loader.
…evels Replaces the sticker_info markup parsing with the listing's structured asset_accessories, which carry each sticker/charm's own description and slot properties — so rows now show Steam's per-accessory attribute line (Sticker Scrape Level from propertyid 4, Charm Template from 3) with icons served from the economy image CDN like every other item icon.
Replaces the modal header in the market layout with panel-native chrome (skincraft attribution and close up top, paired previous/next pager in the footer), gives accessory rows breathing room, and moves the card launcher into the price row as a plain 3D button sized to Steam's own Buy button.
Injects a View in 3D action beside each dialog pane's Inspect in Game link (skipping accessory inspect links by matching the pane listing's own hex), styled to the native button. Opening dismisses Steam's dialog via its own Escape path first, and the shared launcher behaviour moves into a common base for the card and dialog buttons.
ykns3
marked this pull request as ready for review
August 24, 2026 18:43
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
GODrums
requested changes
Aug 29, 2026
GODrums
left a comment
GODrums
left a comment
Collaborator
There was a problem hiding this comment.
A few UX things I noticed:
- it might be worth to have some sort of animation on previous/next to make the transition more obvious
- while the dialog is open, we should block the scrolling in the background (e.g. when hovering over the backdrop)
Collaborator
Author
|
Both UX points from the review addressed in da313b6: prev/next now runs a continuous slide transition (old content out, new in from the direction of travel, clipped to the panel, scroll reset to top), and page scrolling is locked behind the backdrop while the dialog is open — yielding briefly to Steam's own pagination loader (455d4ad). |
Step7750
reviewed
Aug 31, 2026
view_3d.ts was the only file in the repo holding two custom elements; the shared base and each launcher now get their own file.
The details panel's action opens Steam's own purchase dialog and never runs a purchase itself, so the chain above the click reads as viewing a listing: onViewMarketListing through the embed service to view-listing/view-result. Only the page-script helper that clicks Steam's native Buy button keeps buy in its name.
Step7750
approved these changes
Sep 2, 2026
…election The prev/next ghost copies the scroll area's offsetHeight onto a content-box element, so it rendered 32px into the footer and slid away over the nav buttons. The nav and View buttons also no longer select their label on a double-click.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 69e6c9e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detailslayout mirrors Steam's item dialog (wear bar, properties, accessories, restrictions, description) with Previous/Next, arrow keys, and a Buy hand-off to Steam's native purchase flow.buy-result): the viewer only closes when a native Buy button was clicked, and shows a notice otherwise. The price shown is the buyer total (unPrice + unFee) in Steam's own localized format.Validation
npm test(68 passed)npm run lintnpm run checkformatnpm run buildnpx tsc --noEmitNote
Medium Risk
Touches Market purchase hand-off (native Buy clicks) and cross-context postMessage, but payments stay on Steam; protocol validation and timeouts limit malformed or failed hand-offs.
Overview
Adds 3D launchers on the React Market beta—on each listing card and beside the item dialog’s inspect link—gated on WebGPU like inventory. Opening uses the embedded SkinCraft viewer with a new
detailslayout (replacing the inventory grid strip): wear bar, props, accessories, restrictions, and description lines mapped from fiber listing data.Navigation uses Previous/Next, arrow keys, and embed-forwarded keys while the dialog keeps focus; nearing the end triggers
request-itemsso the page scrolls Steam’s grid and returns more targets. View hands off to Steam’s native Buy viaview-listing/view-result; the modal closes only on success and shows a notice on failure.Modal styles are split into modules;
FLOAT_CONDITION_BANDSis shared with the float bar.skincraft_market_targetsharvests listings from React fibers; viewer protocol validation expands for listing details and new message types.happy-domsupports new market-target tests.Reviewed by Cursor Bugbot for commit 69e6c9e. Bugbot is set up for automated code reviews on this repo. Configure here.