Yh cyber windowed blending sampler by yh-cyber · Pull Request #53 · cssu/terrain-diffusion

yh-cyber · 2026-08-21T23:14:51Z

Summary

Validation

scripts/quality-check.sh passes locally
Appropriate /test commands were run and are passing (e.g. /test gpu)
Unit tests were added / e2e tests were added where applicable
Manual testing, if applicable (describe further): added test_sampler file to add unit tests, all pass

Checklist

The change is focused and easy to review.
Tests were added or updated for behaviour changes.
No secrets, generated files, or files that only make sense on my machine are included.
Relevant documentation is updated.

Additional Comments

I think there might be something wrong with scripts/quality-check.sh for me.

This is what I got when I ran scripts/quality-check.sh

$ scripts/quality-check.sh
==> Checking formatting (ruff format --check)
17 files already formatted

==> Checking code style (ruff check)
error: a value is required for '[FILES]...' but none was supplied

For more information, try '--help'.

Found style problems. Many can be fixed automatically with:
  scripts/format-check.sh --fix
(terrain-diffusion) 


$ uv run ruff check src tests
All checks passed!
(terrain-diffusion)

coveralls · 2026-08-21T23:16:17Z

Coverage Report for CI Build 32536161368

Coverage increased (+1.2%) to 97.921%

Details

Coverage increased (+1.2%) from the base build.
Patch coverage: 189 of 189 lines across 2 files are fully covered (100%).
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	529
Covered Lines:	518
Line Coverage:	97.92%
Coverage Strength:	0.98 hits per line

💛 - Coveralls

KurbyDoo

overall the structure looks good, just some things to clean up function boundaries and make testing easier

KurbyDoo · 2026-08-22T05:31:00Z

+    column_distance = np.abs(columns - center_column)
+
+    # weight: apply formula. multiplied 0.9 so values stay above 0
+    row_weight = 1 - 0.9 * row_distance / (height / 2)


should this be (height - 1) / 2 and (width - 1) / 2? If so reuse center_row and center_column

KurbyDoo · 2026-08-22T05:51:14Z

+) -> list[tuple[int, int]]:
+    """Takes a region height and width, a window size, and a step size, and returns the list of top left positions to place windows at.
+    The step is smaller than the window, which is what makes them overlap.
+    If step does not divide evenly (extends), push last window to row/column of region_cl/row - window_size, so that no window hangs over the edge."""


Lets change this to assert that the region is divisible by the window size, this will simplify the function body

so throw an error if the window is not divisible

KurbyDoo · 2026-08-22T05:53:06Z

+    return positions
+
+
+def weight_grid(height: int, width: int) -> np.ndarray:


if the window size is always going to be square, lets change the parameters to only take in an edge length

then we can simplify the body below to not compute separately for columns and rows

KurbyDoo · 2026-08-22T05:54:46Z

+    seed: int, height: int, width: int, window_size: int, step: int, pipeline, store
+) -> np.ndarray:
+    """Make noise canvas of given dimensions. Make noise and weight grid.
+    For each window position, cut the window out of the noise canvas, send it to pipeline (#23), add the processed output and its weight to Terrain Store (at that position).


can you clean up the comments to avoid referencing the issue numbers

KurbyDoo · 2026-08-22T05:55:34Z

+
+        processed_patch = pipeline.generate(
+            window
+        )  # based on unmerged commit i believe this will be pipeline.generate(window)


~~should be merged now, could you rebase to verify?~~
sorry nevermind it isn't merged and similar to the store, I think we want to change this to not take in a pipeline object, see the comment on the header of this function

KurbyDoo · 2026-08-22T05:58:11Z

+            window
+        )  # based on unmerged commit i believe this will be pipeline.generate(window)
+
+        store.add(processed_patch, row, column, weights)


I think the interface for store might be a bit different, but this is fine for now

KurbyDoo · 2026-08-22T06:00:56Z

+    def test_greater_zero(self):
+        "Assert every value is greater than zero"
+        weights = weight_grid(10, 20)
+        assert np.all(weights > 0)


Can you add a test with concrete values, pick a 9x9 region with 3x3 window size and assert the window matches to a deterministic 9x9 grid

KurbyDoo · 2026-08-22T06:02:04Z

+    return weights
+
+
+def starting_noise(seed: int, height: int, width: int) -> np.ndarray:


can you rename to something general to what the function does? like generate_noise_from_seed or something

KurbyDoo · 2026-08-22T06:04:12Z

+        assert noise.shape == (height, width)
+
+
+class FakePipeline:


nit: you can call objects "Mocks" if they are fake representations of a object to be built later

actually, can you look into the mocker pytest fixture to generate mocks for these objects instead of creating new classes?

KurbyDoo · 2026-08-22T06:09:48Z

+    return generator.random((height, width))
+
+
+def produce_region(


lets not pass the store into this function, instead make the function return the weight and weighted sum grid. the caller of this method should be responsible for caching in the terrain store afterwards, this way we can avoid making mocks for the store in this change

~~and same with the pipeline, this function looks like its trying to do what generation orchestration does ~~
for now lets keep the pipeline but remove the store, we can change this later

KurbyDoo · 2026-08-22T06:24:45Z

I have a fix for the script error? Could you take a look #54

yh-cyber added 22 commits August 12, 2026 16:52

first subticket: defining boundaries

e79fc17

starting on second subticket

5e18683

starting on second subticket

3d64f9b

working on window_postions function

89ba124

adding to sampler.py

beb3931

fixed problem in test_sampler

fb3d757

adding to #33

cb3be37

adding to tests/sampler

10897e9

finished test class for #33

7dba7ee

minor fix

fc3fe36

Merge branch 'main' into yh-cyber-windowed-blending-sampler

beb9bca

completed #33

4036106

starting #34

afb2ea1

finished tests for #34

c8765cb

finished #34

94f3a6f

setting up for #35

347bbae

layout structure for produce_region

6d8af62

done produce_region, working on tests

fac8f56

working on fakestore

5f739e2

Merge branch 'main' into yh-cyber-windowed-blending-sampler

82d9964

finished subissue 35

13a135e

fixing script quality check errors

e6641cc

yh-cyber linked an issue Aug 21, 2026 that may be closed by this pull request

Clean every window and add the results into the region grids #35

Open

yh-cyber requested a review from KurbyDoo August 21, 2026 23:15

This was linked to issues Aug 21, 2026

Create the starting noise for a region #34

Open

Work out where the windows go over a region #32

Open

Build the weight grid for a patch #33

Open

Defined Boundaries #50

Open

Define the component boundaries #5

Open

Windowed Blending Sampler #4

Open

KurbyDoo requested changes Aug 22, 2026

View reviewed changes

		return positions


		def weight_grid(height: int, width: int) -> np.ndarray:

		return weights


		def starting_noise(seed: int, height: int, width: int) -> np.ndarray:

Uh oh!

Conversation

yh-cyber commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Checklist

Additional Comments

Uh oh!

coveralls commented Aug 21, 2026

Coverage Report for CI Build 32536161368

Coverage increased (+1.2%) to 97.921%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

KurbyDoo left a comment

Choose a reason for hiding this comment

Uh oh!

KurbyDoo Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KurbyDoo Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KurbyDoo Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KurbyDoo commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yh-cyber commented Aug 21, 2026 •

edited

Loading

KurbyDoo Aug 22, 2026 •

edited

Loading

KurbyDoo Aug 22, 2026 •

edited

Loading

KurbyDoo Aug 22, 2026 •

edited

Loading